Merge pull request #537 from LinqLover/feat/github-shortcuts

Add shortcuts for fetching GitHub repositories
Metacello · Feb 16, 2021 · a2336b0 · a2336b0
2 parents f336f66 + 97a0bb1
commit a2336b0
Show file tree

Hide file tree

Showing 8 changed files with 116 additions and 11 deletions.
diff --git a/docs/MetacelloScriptingAPI.md b/docs/MetacelloScriptingAPI.md
@@ -536,6 +536,7 @@ is rooted in the projects HOME directory.
 * croquet:
 * filetreeDirectory:
 * gemsource:
+* githubUser:project:path:
 * githubUser:project:commitish:path:
 * impara:
 * renggli:

diff --git a/...ory/Metacello-Base.package/Metacello.class/instance/githubUser.project.commitish.path..st b/...ory/Metacello-Base.package/Metacello.class/instance/githubUser.project.commitish.path..st
@@ -1,10 +1,10 @@
 api repository shortcuts
 githubUser: userName project: projectName commitish: commitish path: path
-  | branchOrCommitOrTag |
-  branchOrCommitOrTag := commitish.
-  branchOrCommitOrTag isEmpty
-    ifTrue: [ branchOrCommitOrTag := 'master' ].
-  self
-    repository:
-      'github://' , userName , '/' , projectName , ':' , branchOrCommitOrTag , '/'
-        , path
+	"commitish can be a branch name, commit hash, or tag."
+
+	self repository: (
+		'github://' , userName , '/' , projectName , (
+			(commitish isNil or: [commitish isEmpty])
+				ifTrue: ['']
+				ifFalse: [':' , commitish]
+		) , '/' , path)
diff --git a/repository/Metacello-Base.package/Metacello.class/instance/githubUser.project.path..st b/repository/Metacello-Base.package/Metacello.class/instance/githubUser.project.path..st
@@ -0,0 +1,8 @@
+api repository shortcuts
+githubUser: userName project: projectName path: path
+
+	^ self
+		githubUser: userName
+		project: projectName
+		commitish: nil
+		path: path
diff --git a/repository/Metacello-Base.package/Metacello.class/methodProperties.json b/repository/Metacello-Base.package/Metacello.class/methodProperties.json
@@ -23,7 +23,8 @@
 		"filetreeDirectory:" : "dkh 07/25/2013 15:21",
 		"gemsource:" : "dkh 06/28/2013 16:52",
 		"get" : "dkh 09/30/2014 13:59",
-		"githubUser:project:commitish:path:" : "dkh 07/25/2013 15:26",
+        "githubUser:project:path:" : "ct 11/7/2020 20:12",
+		"githubUser:project:commitish:path:" : "ct 11/7/2020 20:15",
 		"ignoreImage" : "dkh 6/13/2012 16:05",
 		"impara:" : "dkh 7/17/2012 16:48",
 		"list" : "dkh 09/30/2014 14:00",

diff --git a/repository/Metacello-Base.package/monticello.meta/version b/repository/Metacello-Base.package/monticello.meta/version
diff --git a/...umentationIssue196EnableUndefinedTestCase.class/instance/testGettingStartedWithGitHub2.st b/...umentationIssue196EnableUndefinedTestCase.class/instance/testGettingStartedWithGitHub2.st
@@ -0,0 +1,10 @@
+tests
+testGettingStartedWithGitHub2
+  Metacello new
+    baseline: 'External';
+    githubUser: 'dalehenrich' project: 'external' commitish: MetacelloScriptingResource externalCustomSHA path: 'repository';
+    load.
+  Metacello image
+    baseline: 'External';
+    get;
+    load
diff --git a/...umentationIssue196EnableUndefinedTestCase.class/instance/testGettingStartedWithGitHub3.st b/...umentationIssue196EnableUndefinedTestCase.class/instance/testGettingStartedWithGitHub3.st
@@ -0,0 +1,10 @@
+tests
+testGettingStartedWithGitHub3
+  Metacello new
+    baseline: 'External';
+    githubUser: 'dalehenrich' project: 'external' path: 'repository';
+    load.
+  Metacello image
+    baseline: 'External';
+    get;
+    load
diff --git a/...etacelloScriptingDocumentationIssue196EnableUndefinedTestCase.class/methodProperties.json b/...etacelloScriptingDocumentationIssue196EnableUndefinedTestCase.class/methodProperties.json
@@ -3,5 +3,7 @@
 		 },
 	"instance" : {
 		"disableUndefinedSymbolTracking" : "dkh 07/06/2016 15:59",
-		"testGettingStartedWithGitHub1" : "dkh 07/06/2016 16:00",
+        "testGettingStartedWithGitHub1" : "dkh 07/06/2016 16:00",
+        "testGettingStartedWithGitHub2" : "ct 02/15/2021 20:10",
+        "testGettingStartedWithGitHub3" : "ct 02/15/2021 20:10",
 		"testLockCommandReference6" : "dkh 07/06/2016 16:00" } }