feat!: Add --manifest option for custom manifest to dev server
#3793
+151
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }: CheckManifestOptions = {}, | ||
| ): Promise<CheckManifestResult> { | ||
| const manifestPath = pathUtils.join(basePath, NpmSnapFileNames.Manifest); | ||
| const basePath = dirname(manifestPath); |
Member
There was a problem hiding this comment.
Is this meant to require that the manifest is in the root of the package still? If it isn't, the following lines break, when looking for the package.json etc
| task: async ({ config, spinner }) => { | ||
| await watch(config, { spinner }); | ||
| task: async ({ config, options, spinner }) => { | ||
| const configWithManifest = options.manifestPath |
Member
There was a problem hiding this comment.
Should this be merged into the config further up the call stack?
Member
Author
There was a problem hiding this comment.
You're right, merging this before calling the watch handler is a lot simpler actually. Not sure why I didn't think of that in the first place 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--manifestoption to the Snaps CLI dev server (mm-snap watch), which can be used to specify a different manifest file to use for the Snap, e.g., a separate development manifest with initial connections or additional permissions used for testing purposes only.In a follow up PR it will be possible to extend the main manifest file, so it's no longer needed to copy the entire manifest.
Breaking changes
snaps-utils'checkManifestfunction now takes the path to the manifest rather than the base directory containing a manifest. This is needed to allow specifying custom manifests.