feat: warn on self-sends in sendTransfer confirmation

packages/snap/CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Show a self-send warning in the send confirmation when the recipient address belongs to the sending account ([#607](https://github.com/MetaMask/snap-bitcoin-wallet/pull/607))
 - Show a confirmation dialog before signing a PSBT from KeyringHandler and sending a transfer ([#591](https://github.com/MetaMask/snap-bitcoin-wallet/pull/591))
 - Add `resolveAccountAddress` method to KeyringHandler for dApp connectivity ([#590](https://github.com/MetaMask/snap-bitcoin-wallet/pull/590))
 

packages/snap/locales/de.json

@@ -208,6 +208,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Transaktionsanfrage"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Anfrage von"
     }

packages/snap/locales/el.json

@@ -208,6 +208,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Αίτημα συναλλαγής"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Ζητήθηκε από"
     }

packages/snap/locales/en.json

@@ -211,6 +211,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Transaction request"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Request from"
     },

packages/snap/locales/es.json

@@ -208,6 +208,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Solicitud de transacción"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Solicitud de"
     }

packages/snap/locales/es_419.json

@@ -208,6 +208,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Solicitud de transacción"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Solicitud de"
     }

packages/snap/locales/fr.json

@@ -208,6 +208,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Demande de transaction"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Demande de la part de"
     }

packages/snap/locales/hi.json

@@ -208,6 +208,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "ट्रांसेक्शन रिक्वेस्ट"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "इनसे मिला अनुरोध"
     }

packages/snap/locales/id.json

@@ -208,6 +208,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Permintaan transaksi"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Permintaan dari"
     }

packages/snap/locales/ja.json

@@ -208,6 +208,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "トランザクションリクエスト"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "要求元"
     }

packages/snap/locales/ko.json

@@ -178,6 +178,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "트랜잭션 요청"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "요청자:"
     }

packages/snap/locales/pt.json

@@ -178,6 +178,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Solicitação de transação"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Solicitação de"
     }

packages/snap/locales/ru.json

@@ -178,6 +178,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Запрос транзакции"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Запрос от"
     }

packages/snap/locales/tl.json

@@ -178,6 +178,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Hiling na transaksyon"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Kahilingan mula sa/kay"
     }

packages/snap/locales/tr.json

@@ -178,6 +178,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "İşlem talebi"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Talebi gönderen"
     }

packages/snap/locales/vi.json

@@ -178,6 +178,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "Yêu cầu giao dịch"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "Yêu cầu từ"
     }

packages/snap/locales/zh_CN.json

@@ -178,6 +178,12 @@
     "confirmation.signAndSendTransaction.title": {
       "message": "交易请求"
     },
+    "confirmation.signAndSendTransaction.selfSend.title": {
+      "message": "Sending to your own address"
+    },
+    "confirmation.signAndSendTransaction.selfSend.description": {
+      "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+    },
     "confirmation.requestOrigin": {
       "message": "请求来自"
     }

packages/snap/messages.json

@@ -209,6 +209,12 @@
   "confirmation.signAndSendTransaction.title": {
     "message": "Transaction request"
   },
+  "confirmation.signAndSendTransaction.selfSend.title": {
+    "message": "Sending to your own address"
+  },
+  "confirmation.signAndSendTransaction.selfSend.description": {
+    "message": "The recipient address belongs to this wallet. The amount will stay in your account, but network fees still apply."
+  },
   "confirmation.requestOrigin": {
     "message": "Request from"
   },

packages/snap/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snap-bitcoin-wallet.git"
   },
   "source": {
-    "shasum": "1jbPT93y4v8JjV5Sj8zdfhhk9Eq1GJrTjSjciRYsl4c=",
+    "shasum": "ULNv7Bt/BuxJkLiIo7x79kO0vVLtnZj8CxGoa2bEQ+M=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

packages/snap/src/entities/send-flow.ts

@@ -18,6 +18,7 @@ export type ConfirmSendFormContext = {
   locale: string;
   psbt: string;
   origin?: string;
+  isMine: boolean;
 };
 
 export type SendFormContext = {

packages/snap/src/infra/jsx/unified-send-flow/UnifiedSendFormView.tsx

@@ -2,6 +2,7 @@ import { Psbt } from '@metamask/bitcoindevkit';
 import type { SnapComponent } from '@metamask/snaps-sdk/jsx';
 import {
   Address,
+  Banner,
   Heading,
   Link,
   Section,
@@ -43,6 +44,7 @@ export const UnifiedSendFormView: SnapComponent<UnifiedSendFormViewProps> = ({
     recipient,
     explorerUrl,
     origin,
+    isMine,
   } = context;
 
   const psbt = Psbt.from_string(context.psbt);
@@ -60,6 +62,17 @@ export const UnifiedSendFormView: SnapComponent<UnifiedSendFormViewProps> = ({
           <Box>{null}</Box>
         </Box>
 
+        {isMine ? (
+          <Banner
+            title={t('confirmation.signAndSendTransaction.selfSend.title')}
+            severity="warning"
+          >
+            <SnapText>
+              {t('confirmation.signAndSendTransaction.selfSend.description')}
+            </SnapText>
+          </Banner>
+        ) : null}
+
         <Section>
           <Box>
             <SnapText fontWeight="medium" color="alternative">

packages/snap/src/store/JSXConfirmationRepository.test.tsx

@@ -28,6 +28,7 @@ import { UnifiedSendFormView } from '../infra/jsx/unified-send-flow';
 jest.mock('@metamask/bitcoindevkit', () => ({
   Address: {
     from_script: jest.fn(),
+    from_string: jest.fn(),
   },
 }));
 
@@ -110,10 +111,12 @@ describe('JSXConfirmationRepository', () => {
   });
 
   describe('insertSendTransfer', () => {
+    const mockRecipientScript = mock<ScriptBuf>();
     const mockAccount = mock<BitcoinAccount>({
       id: 'account-id',
       network: 'bitcoin',
       publicAddress: mock<Address>({ toString: () => 'fromAddress' }),
+      isMine: () => false,
     });
     const mockPsbt = mock<Psbt>({
       toString: () => 'serialized-psbt',
@@ -132,6 +135,9 @@ describe('JSXConfirmationRepository', () => {
       mockRatesClient.spotPrices.mockResolvedValue(
         mock<SpotPrice>({ price: 50000 }),
       );
+      MockedBdkAddress.from_string.mockReturnValue(
+        mock<Address>({ script_pubkey: mockRecipientScript }),
+      );
     });
 
     it('creates and displays a send transfer interface', async () => {
@@ -151,6 +157,7 @@ describe('JSXConfirmationRepository', () => {
         locale: 'en',
         psbt: 'serialized-psbt',
         origin,
+        isMine: false,
       };
 
       expect(mockSnapClient.getPreferences).toHaveBeenCalled();
@@ -170,6 +177,44 @@ describe('JSXConfirmationRepository', () => {
       );
     });
 
+    it('marks the recipient as isMine when it belongs to the account', async () => {
+      const selfSendAccount = mock<BitcoinAccount>({
+        id: 'account-id',
+        network: 'bitcoin',
+        publicAddress: mock<Address>({ toString: () => 'fromAddress' }),
+        isMine: () => true,
+      });
+
+      await repo.insertSendTransfer(
+        selfSendAccount,
+        mockPsbt,
+        recipient,
+        origin,
+      );
+
+      expect(MockedBdkAddress.from_string).toHaveBeenCalledWith(
+        recipient.address,
+        selfSendAccount.network,
+      );
+      expect(mockSnapClient.createInterface).toHaveBeenCalledWith(
+        undefined,
+        expect.objectContaining({ isMine: true }),
+      );
+    });
+
+    it('defaults isMine to false when the recipient address fails to parse', async () => {
+      MockedBdkAddress.from_string.mockImplementation(() => {
+        throw new Error('Invalid address');
+      });
+
+      await repo.insertSendTransfer(mockAccount, mockPsbt, recipient, origin);
+
+      expect(mockSnapClient.createInterface).toHaveBeenCalledWith(
+        undefined,
+        expect.objectContaining({ isMine: false }),
+      );
+    });
+
     it('throws UserActionError if the user cancels', async () => {
       mockSnapClient.displayConfirmation.mockResolvedValue(false);
       await expect(
@@ -182,6 +227,7 @@ describe('JSXConfirmationRepository', () => {
         id: 'account-id',
         network: 'testnet',
         publicAddress: mock<Address>({ toString: () => 'fromAddress' }),
+        isMine: () => false,
       });
 
       await repo.insertSendTransfer(

packages/snap/src/store/JSXConfirmationRepository.tsx

@@ -88,6 +88,17 @@ export class JSXConfirmationRepository implements ConfirmationRepository {
     const { locale, currency: fiatCurrency } =
       await this.#snapClient.getPreferences();
 
+    let isMine = false;
+    try {
+      const recipientScript = BdkAddress.from_string(
+        recipient.address,
+        account.network,
+      ).script_pubkey;
+      isMine = account.isMine(recipientScript);
+    } catch {
+      isMine = false;
+    }
+
     const context: ConfirmSendFormContext = {
       from: account.publicAddress.toString(),
       explorerUrl: this.#chainClient.getExplorerUrl(account.network),
@@ -99,6 +110,7 @@ export class JSXConfirmationRepository implements ConfirmationRepository {
       locale,
       psbt: psbt.toString(),
       origin,
+      isMine,
     };
 
     const messages = await this.#translator.load(locale);