Skip to content

feat: add scripts from metamask template #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

feat: add scripts from metamask template #17

merged 1 commit into from
Jul 15, 2025

Conversation

ieow
Copy link
Collaborator

@ieow ieow commented Jul 15, 2025

  • add scripts that needed for publish

@ieow ieow requested a review from a team as a code owner July 15, 2025 11:26
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Script Fails on Unset Variables Before Validation

The set -u option causes the script to exit with an "unbound variable" error when $1 or $2 are unset during assignment. This prevents the script from reaching its intended validation checks and providing helpful error messages for missing arguments.

scripts/get.sh#L2-L22

set -e
set -u
set -o pipefail
if [[ ${RUNNER_DEBUG:-0} == 1 ]]; then
set -x
fi
KEY="${1}"
OUTPUT="${2}"
if [[ -z $KEY ]]; then
echo "Error: KEY not specified."
exit 1
fi
if [[ -z $OUTPUT ]]; then
echo "Error: OUTPUT not specified."
exit 1
fi

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link

@smgv smgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ieow ieow merged commit 23e9c44 into main Jul 15, 2025
24 checks passed
@ieow ieow deleted the feat/add_scripts branch July 15, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants