Skip to content

Conversation

@christopherferreira9
Copy link
Contributor

@christopherferreira9 christopherferreira9 commented Nov 4, 2025

Description

This PR removes animations for E2E only. These animations were causing timers to appear for Detox as animations would go on in loop. To overcome this we've been relying on device.disableSynchronization() which causes a handful of new issues and flakiness.
Removing animations allows us to stop using disableSynchronization on Confirmation tests.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Disables UI animations in E2E, adds stable price API mocks, trims network allowlist, updates selectors, and removes Detox synchronization disabling across send/account-sync tests.

  • E2E runtime/animations:
    • In app/components/Views/Root/index.tsx, set ReducedMotionConfig to ReduceMotion.Always when isE2E.
    • In TradeWalletActions.tsx, bypass enter/exit animations and perform immediate navigation.goBack() in E2E.
  • API mocking and allowlist:
    • Add comprehensive mock for GET https://price.api.cx.metamask.io/v1/exchange-rates?baseCurrency=usd in e2e/api-mocking/mock-responses/defaults/price-apis.ts.
    • Remove unused client-config URLs from e2e/api-mocking/mock-e2e-allowlist.ts.
  • Test updates:
    • Replace getElementByText('5') with getElementByLabel('5') in RedesignedSendView.
    • Remove calls to device.disableSynchronization() (and related enableSynchronization) across send and multi-SRP specs.
    • Minor fixture cleanup in send specs (e.g., dapp setup removed where unneeded).

Written by Cursor Bugbot for commit 3023daf. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested review from a team as code owners November 4, 2025 15:49
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Nov 4, 2025
@github-actions github-actions bot added the size-S label Nov 4, 2025
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 4, 2025
cursor[bot]

This comment was marked as outdated.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner November 4, 2025 18:17
@christopherferreira9 christopherferreira9 force-pushed the christopher/disable-e2e-animations-confirmations branch from 8c5ac28 to 3023daf Compare November 4, 2025 18:28
@github-actions github-actions bot added size-L and removed size-S labels Nov 4, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
37.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 marked this pull request as draft November 4, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-L team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants