Skip to content

feat: wallet selector #17502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: wallet selector #17502

wants to merge 12 commits into from
+200 −6

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jul 23, 2025 •
edited
Loading

Description

This PR adds a selector for wallets. This selector is not used at the moment.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-445?atlOrigin=eyJpIjoiNWNiODc2YjYzMWJhNGM3ZGJmMWMxOGJiMmJiMTQwMmYiLCJwIjoiaiJ9

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev requested a review from a team as a code owner July 23, 2025 13:40
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]

This comment was marked as outdated.

Sign in to view

@montelaidev montelaidev added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing labels Jul 24, 2025
@montelaidev montelaidev self-assigned this Jul 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 65a4162
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf11b96d-6ef3-4608-8ec3-5b467d5eab96

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@montelaidev montelaidev added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5a741f2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/252f74ff-0da6-4e62-8af5-0c314fd6932d

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@montelaidev montelaidev enabled auto-merge July 25, 2025 14:16
owencraston
owencraston reviewed Jul 25, 2025
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. the only gripe I have is with the placement. We currently have two folders that seem to handle similar work....

app/multichain-accounts/selectors/accountTreeController.ts
app/selectors/multichainAccounts/wallets.ts

Perhaps we should move the accountTreeController into app/selectors/multichainAccounts/

@montelaidev montelaidev requested a review from a team as a code owner July 28, 2025 14:16
@montelaidev montelaidev added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 28, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 27ad796
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9aa4cc85-a9b2-4021-93e1-d5f3f4eb3e72

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@montelaidev montelaidev added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6dd762c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d472b17e-df79-4672-85c5-0909af8e6de3

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@montelaidev montelaidev added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2459aec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/79734dd3-5617-415e-90cf-140546e85b96

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@montelaidev montelaidev added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 68623f9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc669c4b-9913-48ef-a5fd-9a22c7d205e7

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owencraston owencraston owencraston left review comments

@cursor cursor[bot] cursor[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@montelaidev montelaidev

Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montelaidev @owencraston @metamaskbot