Skip to content

fix: fix sentry noice related to undefined currentCurrency property w… #15977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: fix sentry noice related to undefined currentCurrency property w… #15977

wants to merge 2 commits into from
+25 −4

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jun 2, 2025 •
edited
Loading

…hen app start

Description

Related issues

Fixes: #14504

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

salimtb
salimtb commented Jun 2, 2025
View reviewed changes
app/store/migrations/069.ts
@@ -23,16 +23,15 @@ export default function migrate(state: unknown) {
const currencyController =
state.engine.backgroundState.CurrencyRateController;

if (
!isObject(currencyController) ||
!hasProperty(currencyController, 'currentCurrency')
Copy link
Contributor Author

@salimtb salimtb Jun 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At app startup, the currentCurrency property is sometimes not yet defined, which has been triggering a Sentry error. To reduce noise, we’ve added a silent return in that case. In parallel, we’ll investigate why this property is occasionally missing during initialization.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@salimtb salimtb added the Run Smoke E2E Requires smoke E2E testing label Jun 2, 2025
@salimtb salimtb marked this pull request as ready for review June 2, 2025 13:55
@salimtb salimtb requested a review from a team as a code owner June 2, 2025 13:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c43f6ba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4bc367a5-baf8-4a5b-8205-b3d64f9bca05

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added no-changelog Indicates no external facing user changes, therefore no changelog documentation needed No QA Needed Apply this label when your PR does not need any QA effort. labels Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E Requires smoke E2E testing team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sentry] Error: Migration: Invalid CurrencyController state type 'undefined'
3 participants
@salimtb @Prithpal-Sooriya @metamaskbot