perf: accounts improvements

[ccharly]

Description

Caution

Requires this PR to be merged first:

• Chore: upgrade assets controller v60 #14913

Upgrade controllers to use the new accounts perf improvements, notably:

• perf(accounts-controller): prevent unnecessary update with SnapController:stateChange core#5735
• perf(keyring-controller): do not fire unnecessary :stageChange in withKeyring core#5732
• perf(accounts-controller): add new setAccountNameAndSelectAccount action core#5714

Related issues

N/A

Manual testing steps

1. Create a Solana account
2. It should run faster

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​metamask/​multichain-transactions-controller@​0.8.0 ⏵ 0.10.0	+1		+1	+3
	npm/​@​metamask/​earn-controller@​0.12.0 ⏵ 0.13.0	+3			+2
	npm/​@​metamask/​multichain-network-controller@​0.5.1 ⏵ 0.6.0				+2
	npm/​@​metamask/​bridge-status-controller@​16.0.0 ⏵ 18.0.0	-5		+1	+1
	npm/​@​metamask/​accounts-controller@​27.0.0 ⏵ 28.0.0	+1		+1	-2
	npm/​@​metamask/​keyring-controller@​21.0.4 ⏵ 21.0.6			+1	+1
	npm/​@​metamask/​signature-controller@​27.1.0 ⏵ 28.0.0				+2
	npm/​@​metamask/​bridge-controller@​20.0.0 ⏵ 21.0.0	-9		-24	-1
	npm/​@​metamask/​user-operation-controller@​33.0.0 ⏵ 34.0.0				+2
	npm/​@​metamask/​transaction-controller@​54.0.0 ⏵ 55.0.0			+1	+1
	npm/​@​metamask/​profile-sync-controller@​12.0.0 ⏵ 13.0.0				+2
	npm/​@​metamask/​notification-services-controller@​6.0.0 ⏵ 7.0.0	+1		+1	+1
	npm/​@​metamask/​assets-controllers@​60.0.0 ⏵ 61.0.0	-1			-1

View full report

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4802c1e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d8de4826-fc9a-40ab-a0d4-5b84fbb8b9d7

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[gantunesr]

Performance tests

Device: Samsung Galaxy A22

Ethereum account creation

// file: app/components/Views/AddAccountActions/AddAccountActions.tsx
// method: addNewHdAccount();

	main	perf/accounts-improvements
Test 1	2.92 secs	2.20 secs
Test 2	2.98 secs	2.39 secs
Test 3	5.36 secs	4.15 secs
Test 4	5.49 secs	4.09 secs
Test 5	3.14 secs	4.20 secs

Solana account creation

// file: app/components/Views/AddNewAccount/AddNewAccount.tsx
// method: multichainWalletSnapClient.createAccount({ ... });

	main	perf/accounts-improvements
Test 1	0.63 secs	0.039 secs
Test 2	0.25 secs	0.061 secs
Test 3	0.29 secs	0.11 secs
Test 4	0.36 secs	0.068 secs
Test 5	0.34 secs	0.064 secs

[gantunesr]

looks good but the CI is still failing

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7e834ae
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dbbaf52a-ab2c-4b3d-8db7-707a3d51a67f

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud