fix: Fix missing invalid password for login #13558

[Cal-L]

Description

Two changes are made in this PR to fix the issue where an invalid password message is missing

• Remove redundant lockApp call from Authentication. This is not needed since the user is already locked out and is on the login screen. The disappearance of the invalid password message was a result of the lockApp action re-navigating to the login screen
• We also consolidating the invalid password logic so that the catch block handles both the password requirement and invalid password scenario

Related issues

Fixes: #13558

Manual testing steps

1. Create a wallet
2. Kill and re-open app to land on the login screen
3. Try entering 2 characters and login, which will result in an invalid password message as a result of failed password requirements
4. Try entering 10 characters, which will result in an invalid password message as a result of a failed vault decryption (wrong password)

Screenshots/Recordings

Before

After

fixed.login.message.mov

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 29134a3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf24b0c2-2985-47d2-8bb4-37a125bcfc60

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
16.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud