Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solana opt-in modal #14298

Merged
merged 15 commits into from
Apr 2, 2025
Merged

feat: solana opt-in modal #14298

merged 15 commits into from
Apr 2, 2025

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Mar 28, 2025

Description

Adding the solana modal to let users know the new feature is available.
For users that already have a solana address, the blue button will say "Got it".
For new users (without a solana account) the button will invite them to create their 1st solana account.
The modal will be visible only once.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live marked this pull request as ready for review March 31, 2025 10:20
@zone-live zone-live requested a review from a team as a code owner March 31, 2025 10:20
@zone-live zone-live requested review from a team as code owners March 31, 2025 13:20
@zone-live zone-live added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 31, 2025
Copy link
Contributor

github-actions bot commented Mar 31, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7e9e901
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a5d93de1-cbc4-4313-bdd9-2acbafdb245d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@zone-live zone-live added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 31, 2025
@zone-live zone-live added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 1, 2025
Copy link
Contributor

github-actions bot commented Apr 1, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: aff983b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/79546e57-bda1-40b1-bae8-2dbdaa312d5f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini previously approved these changes Apr 2, 2025
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just left a comment around reusing the icon from component library!

Copy link

sonarqubecloud bot commented Apr 2, 2025

@zone-live zone-live added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 2, 2025
Copy link
Contributor

github-actions bot commented Apr 2, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a63ad57
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/74944d09-0b37-4296-bd8f-02d205b55d11

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@zone-live
Copy link
Contributor Author

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a63ad57 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/74944d09-0b37-4296-bd8f-02d205b55d11

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Tried 3 times, keeps failing for ramps and swaps, not remotely related with this PR.

@zone-live zone-live added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit f7f7c77 Apr 2, 2025
44 checks passed
@zone-live zone-live deleted the SOL-239-solana-opt-in-modal branch April 2, 2025 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.45.0 Issue or pull request that will be included in release 7.45.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-solana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants