Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #13410: Don't switch networks when 'Close' button is tapped in Add Network flow #14297

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

darkwing
Copy link
Contributor

Description

This PR removes the network switch request when the user taps the Close button instead of "Switch Networks"

Related issues

Fixes: #13410

Manual testing steps

  1. Add a popular network
  2. Press Confirm
  3. Click "Close"

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
darkwing David Walsh
…dd Network flow
@darkwing darkwing requested a review from a team as a code owner March 28, 2025 13:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Mar 28, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@hesterbruikman hesterbruikman added area-design Design bug (previously known as papercuts - ask Hilary for more detail) and removed area-design Design bug (previously known as papercuts - ask Hilary for more detail) labels Mar 31, 2025
…to new network
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Mar 31, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: a95f345
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/96c9d7e3-228e-4b46-93fe-281a1bdba4db

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 31, 2025
Copy link
Contributor

github-actions bot commented Mar 31, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0b1edd1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9a46cce0-9839-4126-a4ad-096dc2d8a496

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 31, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 31, 2025
Copy link
Contributor

github-actions bot commented Mar 31, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 421862b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dea4689f-8f14-4e5d-a1dc-03b93a9ea3cd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 31, 2025
Copy link
Contributor

github-actions bot commented Mar 31, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1b50057
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/04d45e68-b34e-42b6-93da-e7a2f919c28c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
4 participants