Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump @metamask/notification-services-controller to ^5.0.1 #14296

Merged
merged 8 commits into from
Apr 4, 2025
Merged

feat: bump @metamask/notification-services-controller to ^5.0.1 #14296

merged 8 commits into from
Apr 4, 2025
+134 −81

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Mar 28, 2025 •
edited
Loading

Description

Bumps @metamask/notifications-services-controller to ^5.0.1

Relies on keyring controller to be bumped first.
#14304

Related issues

Fixes:

#13890
#14128
#14148

Manual testing steps

Once kerying controller is bumped we need to test Notification Flows.

Enable Notifications

  1. Onboard Wallet
  2. Click Bell
  3. Enable Notifications

Notification Settings

  1. Enable/Disable Notifications
  2. Enable/Disable Push Notifications
  3. Enable/Disable Feature Announcements
  4. Enable/Disable Account Notifications

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners March 28, 2025 13:22
@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as draft March 28, 2025 13:22
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Mar 28, 2025 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] ➜ 5.0.1 None 0 1.38 MB metamaskbot

View full report↗︎

@Prithpal-Sooriya Prithpal-Sooriya changed the title feat: upgrade notifications controller feat: bump @metamask/notification-services-controller to ^5.0.1 Mar 31, 2025
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a83d5be
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7a89d97a-b189-4a64-82be-9df7d71d6abf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Prithpal-Sooriya Prithpal-Sooriya force-pushed the feat/upgrade-notifications-controller branch from c647450 to 3b0f944 Compare March 31, 2025 10:02
@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 31, 2025
@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review March 31, 2025 10:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3b0f944
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/19c2f8fd-e3fb-4fe2-b653-3990e0350b02

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 31, 2025
@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f70f160
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8e7798ab-8377-4762-8682-a246f1f6dcfc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

mathieuartu
mathieuartu previously approved these changes Apr 1, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Apr 1, 2025
tommasini
tommasini previously approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, since KeyringController is almost in and we are aware of it I'm approving this PR

NidhiKJha
NidhiKJha previously approved these changes Apr 1, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 1, 2025
@mathieuartu mathieuartu dismissed stale reviews from NidhiKJha, tommasini, and themself via 89f18b5 April 3, 2025 19:52
@mathieuartu mathieuartu added this pull request to the merge queue Apr 3, 2025
@mathieuartu mathieuartu removed this pull request from the merge queue due to a manual request Apr 3, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mathieuartu mathieuartu added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit 840807e Apr 4, 2025
39 checks passed
@mathieuartu mathieuartu deleted the feat/upgrade-notifications-controller branch April 4, 2025 07:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mathieuartu mathieuartu mathieuartu approved these changes

@cortisiko cortisiko cortisiko approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@gambinish gambinish gambinish approved these changes

@NidhiKJha NidhiKJha NidhiKJha left review comments

@tommasini tommasini tommasini left review comments

Assignees
No one assigned
Labels
release-7.45.0 Issue or pull request that will be included in release 7.45.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Prithpal-Sooriya @mathieuartu @cortisiko @vinnyhoward @gambinish @NidhiKJha @tommasini @metamaskbot