feat: add account syncing

[mathieuartu]

Description

This PR adds account syncing to the mobile client.
This feature, that is currently live on extension, syncs EVM accounts & their names between devices.
With this PR, account syncing will effectively work between extension and mobile!

This PR:

• Moves importAdditionalAccounts so that it occurs after every kind of onboarding. This is important for account syncing as we rely on this to be complete before actually dispatching account syncing. This is done to prevent race conditions that adds accounts at the same time. The same logic is currently applied on extension with the _addAccountsWithBalance method.
• Adds a new useAccountSyncing hook
• Uses this hook in useIdentityEffects so that it reactively dispatches account syncing when all pre-requisites are met.
• Adds new identity Bitrise iOS and Android workflows, and adds new E2E tests for account syncing

Related issues

Fixes:

• https://consensyssoftware.atlassian.net/browse/IDENTITY-63
• Enable account syncing on mobile #12275

Manual testing steps

1. Create a new wallet, note the SRP down
2. Finish onboarding, then add and rename accounts
3. Delete your wallet
4. Onboard again, this time by importing the SRP from step 1
5. Verify that your previously created and renamed accounts are here

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8431a25
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8a48aa39-af31-4f36-a12b-046ee2ccfbe7

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 39ae0f6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9293a40e-50f7-4c7d-a823-d955180569cb

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.56%. Comparing base (44bb493) to head (bdd3296).
Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
app/core/Engine/Engine.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14291      +/-   ##
==========================================
+ Coverage   66.29%   66.56%   +0.26%     
==========================================
  Files        2248     2251       +3     
  Lines       48037    48144     +107     
  Branches     6766     6782      +16     
==========================================
+ Hits        31848    32047     +199     
+ Misses      14172    14076      -96     
- Partials     2017     2021       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a1a97e1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/01776172-ad95-42d6-bcc0-9c2a5cde23cc

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 75d4590
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d02a57c6-61fa-4477-a1c3-6d4b02fe5e97

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cmd-ob]

Validated e2e and locally