Skip to content

chore: Enable e2e testing for flask builds in ci #14283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Conversation

Andepande
Copy link
Member

Description

Enable e2e testing on flask builds in ci to allow engineers and QA to run automated tests early in development, ensuring faster feedback and improved stability

Related issues

Fixes:
NA

Manual testing steps

  1. Ensure the spec files are placed in the directory e2e/specs/flask, similar to the extension repo structure.

  2. Navigate to Bitrise dashboard.

  3. Start a new build for your project.

  4. Select the branch you want to run the tests on.

  5. In the build workflow, add or select the run_e2e_flask_pipeline step to trigger the E2E tests.

  6. Wait for the build to complete and review the E2E test results.

  7. If necessary, fix any issues identified during testing and rerun the pipeline.

Screenshots/Recordings

image

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [z] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Andepande Andepande added team-mobile-platform Mobile Platform team Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 27, 2025
@Andepande Andepande requested a review from a team as a code owner March 27, 2025 23:16
@Andepande Andepande changed the title test: Enable e2e testing for flask builds in ci chore: Enable e2e testing for flask builds in ci Mar 27, 2025
@metamaskbot metamaskbot added the team-qa QA team label Mar 27, 2025
Copy link
Contributor

github-actions bot commented Mar 27, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 62a1764
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9a04568b-167a-4c9f-88f0-a0cb26719c59

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (687f60e) to head (62a1764).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14283      +/-   ##
==========================================
+ Coverage   65.57%   65.72%   +0.14%     
==========================================
  Files        2218     2228      +10     
  Lines       47401    47434      +33     
  Branches     6663     6683      +20     
==========================================
+ Hits        31085    31176      +91     
+ Misses      14326    14263      -63     
- Partials     1990     1995       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Andepande Andepande added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 29, 2025
Copy link
Contributor

github-actions bot commented Mar 29, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cdba09f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a846e57-5e85-442b-b2f5-72a1e215d66f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 🔥 🔥 🔥 🔥

@Andepande Andepande added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 72e7491 Mar 31, 2025
45 of 47 checks passed
@Andepande Andepande deleted the chore-e2e-flask branch March 31, 2025 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.45.0 Issue or pull request that will be included in release 7.45.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform Mobile Platform team team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants