Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ledger singing on re-designed signature pages #14266

Merged
merged 2 commits into from
Mar 31, 2025
Merged

fix: ledger singing on re-designed signature pages #14266

merged 2 commits into from
Mar 31, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Mar 27, 2025

Description

In new designs app was hanged after any error in ledger signing. The PR fixes this issue.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4482

Manual testing steps

  1. Connect to ledger
  2. On test dapp submit signatures
  3. Ensure they works as expected

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Mar 27, 2025
@jpuri jpuri requested a review from a team as a code owner March 27, 2025 05:47
@jpuri jpuri added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Mar 27, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya
Copy link
Contributor

QA builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2af8fa73-3387-408c-8d9e-585721ca8462

Personal Sign, Sign Typed Data v4 and Sign Permit work on iOS and Android.
iOS

ios.mov

Android

android.mp4

Sign with Ledger text is not fully visible:

Screenshot 2025-03-27 at 18 49 40

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Mar 27, 2025
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 28, 2025
Copy link
Contributor

github-actions bot commented Mar 28, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c386f43
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b651b6a-69de-4ef8-ad05-96cccd9c091e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri enabled auto-merge March 28, 2025 11:42
@jpuri jpuri added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit f5fbe5b Mar 31, 2025
38 of 42 checks passed
@jpuri jpuri deleted the ledger_fix branch March 31, 2025 12:16
@github-actions github-actions bot removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Mar 31, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.45.0 Issue or pull request that will be included in release 7.45.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants