-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ledger singing on re-designed signature pages #14266
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
QA builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2af8fa73-3387-408c-8d9e-585721ca8462 Personal Sign, Sign Typed Data v4 and Sign Permit work on iOS and Android. ios.movAndroid android.mp4
![]() |
|
|
Description
In new designs app was hanged after any error in ledger signing. The PR fixes this issue.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4482
Manual testing steps
Screenshots/Recordings
TODO
Pre-merge author checklist
Pre-merge reviewer checklist