fix: unncessary dependencies #36974
Merged
fix: unncessary dependencies #36974
+7
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
n3ps
commented
Oct 18, 2025
| [], | ||
| ); | ||
|
|
||
| const toggleNetworkFilterPopover = useCallback(() => { |
There was a problem hiding this comment.
This was unnecessary as a callback.
More importantly the dependencies imported here aren't used in this component
n3ps
commented
Oct 18, 2025
| <Box className="transaction-list" {...boxProps}> | ||
| {renderFilterButton()} | ||
| {!hideNetworkFilter && ( | ||
| <AssetListControlBar |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +7 -55)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [28ba7c8]
UI Startup Metrics (1291 ± 71 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [645b324]
UI Startup Metrics (1245 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ameliejyc
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
Approving as this all looks fine to me. I'm curious why the code to render the control bar was written like this though with so many dependencies and am wondering if there's any context we don't have. So I'd be keen for @pedronfigueiredo to take a quick look too as I see he implemented it last month.
|
@ameliejyc This looks good to me, thanks for checking. This code was originally duplicated from |
pedronfigueiredo
approved these changes
Oct 20, 2025
metamaskbot
added
the
release-13.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessary callback and dependencies
Changelog
CHANGELOG entry: chore: remove unneccesary callback and dependencies
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Cleans up
UnifiedTransactionListby removing unused env/test logic and popover state/handlers, and directly conditionally renderingAssetListControlBar.renderFilterButton()with direct conditional render ofAssetListControlBarwhen!hideNetworkFilter.getEnvironmentType,ENVIRONMENT_TYPE_*,TEST_CHAINS),isEvmNetwork, popover state/handlers, and relateduseMemo/useCallbackwrappers.getCurrentNetwork,getIsEvmMultichainNetworkSelected) aligned with removed code.Written by Cursor Bugbot for commit 645b324. This will update automatically on new commits. Configure here.