refactor: wallet_createSession should call PermissionController.requestPermissions instead of ApprovalController.addAndShowApprovalRequest

[ffmcgee725]

Description

We created a merger for the Caip25Permission specification in order to enable wallet_addEthereumChain and wallet_switchEthereumChain to call to the PermissionController rather than the ApprovalController for incremental permission requests (i.e. for the permittedChains flow).

PRs implementing these changes
core: MetaMask/core#5283
extension: #30042

We also changed eth_requestAccounts and wallet_requestPermissions handlers to call the PermissionController, but we should now do the change to wallet_createSession handler as well and address this feedback on the Flask Multichain PR (at the moment this is only available on the Flask Multichain PR)

Related issues

Fixes:

Manual testing steps

yarn start:flask

Then

(RECOMMENDED) Use the Multichain Test Dapp

• Video Demo for Interacting w/ Multichain Test Dapp

OR

Form requests manually

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [1240e5b]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (2149 ± 113 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	431	2564	2028	410	197
		domContentLoaded	1816	2460	2074	180	86
		load	1874	2808	2149	234	113
		domInteractive	27	117	42	20	9
		backgroundConnect	15	449	77	92	44
		firstReactRender	16	125	39	27	13
		getState	6	156	38	34	16
		initialActions	0	1	0	0	0
		loadScripts	1377	1939	1590	144	69
		setupStore	8	58	17	14	7
		uiStartup	2024	4250	2546	469	225

[adonesky1]

LGTM!

[metamaskbot]

Builds ready [7346118]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1823 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	315	2129	1740	350	168
		domContentLoaded	1621	2063	1755	111	53
		load	1636	2139	1823	146	70
		domInteractive	25	124	35	25	12
		backgroundConnect	18	251	74	68	33
		firstReactRender	15	71	35	21	10
		getState	5	132	37	39	19
		initialActions	0	1	0	0	0
		loadScripts	1207	1593	1331	93	44
		setupStore	8	69	25	21	10
		uiStartup	1826	3260	2226	426	205