Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent SrpViewSrpText from firing more than once #30658

Merged
merged 4 commits into from
Mar 8, 2025
Merged

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Feb 28, 2025

Description

Ensures that the SrpViewSrpText event doesn't get reported more than once despite rerouting triggered by other events.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to Settings -> Security -> Reveal Seed Phrase
  2. Complete quiz and enter your password
  3. Ensure that the event is only tracked once.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing
Copy link
Contributor Author

This is a temporary measure; we need to figure out why the app is rendering this so often. I think it's due to the location re-renders I pointed out a few weeks ago:
SCR-20250228-odbv

@metamaskbot
Copy link
Collaborator

Builds ready [0c4db27]
Page Load Metrics (1773 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35420821700335161
domContentLoaded15212004174512661
load15292075177313163
domInteractive278039157
backgroundConnect106935209
firstReactRender1573322110
getState55119157
initialActions01000
loadScripts11121578130311455
setupStore86616157
uiStartup17422304202014369
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 119 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

EtherWizard33
EtherWizard33 previously approved these changes Mar 5, 2025
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


return (
<div>
<Tabs
defaultActiveTabName={t('revealSeedWordsText')}
onTabClick={(tabName) => {
if (tabName === 'text-seed') {
console.log('TRACKING EVENT: onTabClick text-seed');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected console.log, correct?

Copy link
Contributor

@gambinish gambinish Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like this log is needed? Can it be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drp, sorry. Will do.

@metamaskbot
Copy link
Collaborator

Builds ready [8e23bc3]
Page Load Metrics (1837 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42620111763324156
domContentLoaded15981998180710953
load16082013183711555
domInteractive168238167
backgroundConnect1265352210
firstReactRender1674382311
getState56717178
initialActions01000
loadScripts11711523134710249
setupStore963252010
uiStartup18462312210513364

@metamaskbot
Copy link
Collaborator

Builds ready [7b69c29]
Page Load Metrics (2054 ± 107 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint49726981968400192
domContentLoaded16922616200520398
load174027122054222107
domInteractive298644157
backgroundConnect12160554120
firstReactRender1570352110
getState66123189
initialActions01000
loadScripts12742022151917283
setupStore95716147
uiStartup192831742328312150
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 65 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing added this pull request to the merge queue Mar 8, 2025
Merged via the queue into main with commit cdd1a02 Mar 8, 2025
74 checks passed
@darkwing darkwing deleted the fix-rogue-event branch March 8, 2025 02:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants