-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent SrpViewSrpText from firing more than once #30658
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [0c4db27]
Page Load Metrics (1773 ± 63 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ui/pages/keychains/reveal-seed.js
Outdated
|
||
return ( | ||
<div> | ||
<Tabs | ||
defaultActiveTabName={t('revealSeedWordsText')} | ||
onTabClick={(tabName) => { | ||
if (tabName === 'text-seed') { | ||
console.log('TRACKING EVENT: onTabClick text-seed'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected console.log, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem like this log is needed? Can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drp, sorry. Will do.
Builds ready [8e23bc3]
Page Load Metrics (1837 ± 55 ms)
|
Builds ready [7b69c29]
Page Load Metrics (2054 ± 107 ms)
Bundle size diffs
|
Description
Ensures that the
SrpViewSrpText
event doesn't get reported more than once despite rerouting triggered by other events.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist