fix: hotfix network version / unresponsive network inpage …

[adonesky1]

…provider (#30111)

Previously the inpage provider would withhold events for chainChanged events (and property value updates, i.e. window.ethereum.chainId and .networkVersion) when the dapp's network was changed to an rpc endpoint that was unresponsive or did not support net_version. The dapp would instead receive a disconnect event.

Now the inpage provider always emits chainChanged and networkChanged events (and exposes the correct values on window.ethereum.chainId and .networkVersion) when the selected network for the dapp has changed regardless of if the network being changed to is responsive or if it supports net_version requests. It does this by having the wallet send a loading for networkVersion when it cannot be resolved (same behavior as before) AND a new isConnected property in the metamask_getProviderState request and metamask_chainChanged events (these are different from the events emittted by window.ethereum). isConnected is derived from whether the NetworkController.state.networkMetadata[].status value is the Available constant.

See: #29936 Providers patch from commit (d919ab6b):
MetaMask/providers#404

window.ethereum.on('accountsChanged', (data) => console.log('accountsChanged', data))
window.ethereum.on('chainChanged', (data) => console.log('chainChanged', data))
window.ethereum.on('networkChanged', (data) => console.log('networkChanged', data))
window.ethereum.on('connect', (data) => console.log('connect', data))
window.ethereum.on('disconnect', (data) => console.log('disconnect', data))

1. Go to a webpage. Enter the following in console
2. Change to Linea, see that the correct values are emitted for the chainChanged and networkChanged events
3. Change to Sepolia, see that the correct values are emitted for the chainChanged and networkChanged events
4. Change to a network that is non-responsive, see that chainChanged emits with the correct chainId, but networkChanged emits with a null value, AND there is a disconnect event emitted
5. Change back to a working network, see that the correct values are emitted for the chainChanged and networkChanged events, AND there is a connect event emitted with the new chainId
6. Do the same above with a responsive network that does not have net_version implemented. Se that the correct values are emitted for the chainChanged, that networkChanged emits null, and that there is no disconnect event emitted

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding
  Standards.

• I've completed the PR template to the best of my ability

• I’ve included tests if applicable

• I’ve documented my code using JSDoc format if applicable

• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	0	178 kB	metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	0	50.3 kB	metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	0	497 kB	metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	+1	953 kB	metamaskbot

View full report↗︎

[adonesky1]

@metamaskbot update-policies

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[metamaskbot]

Builds ready [990860e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1721 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1492	2088	1726	150	72
		domContentLoaded	1476	2075	1699	144	69
		load	1485	2087	1721	147	71
		domInteractive	24	141	43	31	15
		backgroundConnect	10	52	22	14	7
		firstReactRender	16	101	42	27	13
		getState	4	53	13	15	7
		initialActions	0	0	0	0	0
		loadScripts	1097	1665	1270	126	60
		setupStore	6	67	14	16	8
		uiStartup	1697	2442	1977	204	98