Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use network-specific smart transaction feature flags #30094

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Feb 4, 2025

Description

If there are network-specific feature flags for smart transactions, they will take priority over shared smart transaction feature flags.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Turn off some feature flag which is network-specific for smart transactions (e.g. bsc.smartTransactions.extensionActive = false)
  2. See that it's being used over a shared one (smartTransactions.extensionActive)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-transactions Transactions team label Feb 4, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [146fd62]
Page Load Metrics (1669 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1520184716669043
domContentLoaded1512183416398641
load1521184516699244
domInteractive237437168
backgroundConnect979342411
firstReactRender1570342210
getState4381073
initialActions01000
loadScripts1042134611957636
setupStore65616168
uiStartup17322121190011354
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 63 Bytes (0.00%)

@dan437 dan437 added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@dan437 dan437 added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit e48abe6 Feb 4, 2025
76 checks passed
@dan437 dan437 deleted the chain-specific-feature-flags branch February 4, 2025 17:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants