Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated snap header in review permissions screen #30092

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

NidhiKJha
Copy link
Member

In the review permissions screen for snaps, the origin of the snap was missing. This PR fix that

Related issues

Fixes: #30088

Manual testing steps

  1. Connect extension to Snap
  2. Click on getAccounts
  3. The review permissions screen should show Dapp Origin

Screenshots/Recordings

Before

Screenshot 2025-02-04 at 11 40 35 AM

After

Screenshot 2025-02-04 at 11 42 43 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added team-wallet-ux INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 4, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [f9761c6]
Page Load Metrics (1718 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14522216171818991
domContentLoaded14442117168118187
load14532204171818890
domInteractive25129452713
backgroundConnect10107342512
firstReactRender1586382512
getState55217157
initialActions00000
loadScripts10171617122414670
setupStore86518189
uiStartup163024741965228109
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 144 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha enabled auto-merge February 4, 2025 13:27
@NidhiKJha NidhiKJha added this pull request to the merge queue Feb 4, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [d5c2667]
Page Load Metrics (1643 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26621811458489235
domContentLoaded14162172162716479
load14252182164316479
domInteractive239234199
backgroundConnect86720168
firstReactRender1473442311
getState45413157
initialActions01000
loadScripts961129511429244
setupStore56414168
uiStartup16132424186518287
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 203 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit 5e2ebff Feb 4, 2025
71 checks passed
@NidhiKJha NidhiKJha deleted the snap-review-screen branch February 4, 2025 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Snap origin as part of permission request copy
4 participants