Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [POM] Migrate dapp interaction e2e tests to TS and Page Object Model (part1) #30090

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Feb 4, 2025

Description

First PR to migrate dapp interaction e2e tests to TypeScript and the Page Object Model.

Specs migrated:

test/e2e/tests/dapp-interactions/block-explorer.spec.js
test/e2e/tests/dapp-interactions/dapp-interactions.spec.js

Page classes created:

test/e2e/page-objects/pages/confirmations/redesign/add-network-confirmations.ts
test/e2e/page-objects/pages/confirmations/redesign/connect-account-confirmation.ts
test/e2e/page-objects/pages/mocked-page.ts

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue added team-extension-platform e2e-test End to end test for the MetaMask extension team-qa QA team labels Feb 4, 2025
@chloeYue chloeYue requested a review from a team February 4, 2025 11:29
@chloeYue chloeYue self-assigned this Feb 4, 2025
@chloeYue chloeYue requested a review from a team as a code owner February 4, 2025 11:29
@chloeYue chloeYue marked this pull request as draft February 4, 2025 11:30
Copy link
Contributor

github-actions bot commented Feb 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue changed the title test: Chloe tests dapp test: [POM] Migrate dapp interaction e2e tests to TS and Page Object Model (part1) Feb 4, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [cc7d329]
Page Load Metrics (1751 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15321997175112359
domContentLoaded15161986172412460
load15352013175112661
domInteractive2395412010
backgroundConnect973362311
firstReactRender16177423919
getState4141203115
initialActions01000
loadScripts10321534126812560
setupStore76417189
uiStartup172327302031218105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 55 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue removed the request for review from a team February 4, 2025 12:21
@metamaskbot
Copy link
Collaborator

Builds ready [2823ea7]
Page Load Metrics (1890 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15562239190118589
domContentLoaded15292170185617282
load15442235189017886
domInteractive26104462612
backgroundConnect1396372512
firstReactRender16167573818
getState56217189
initialActions01000
loadScripts10681709137215474
setupStore880242311
uiStartup177730622245308148
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 55 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test End to end test for the MetaMask extension team-extension-platform team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants