-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multichain): add block explorer format URLs #30085
Draft
ccharly
wants to merge
3
commits into
main
Choose a base branch
from
feat/multichain-block-explorer-format-urls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+196
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ccharly
force-pushed
the
feat/multichain-block-explorer-format-urls
branch
from
February 4, 2025 10:01
a520dac
to
2e7c23b
Compare
ccharly
force-pushed
the
feat/multichain-block-explorer-format-urls
branch
from
February 4, 2025 10:16
2e7c23b
to
67e8cd8
Compare
danroc
reviewed
Feb 4, 2025
id?: string; | ||
}; | ||
|
||
export type MultichainProviderConfig = ProviderConfigWithImageUrl & { | ||
nickname: string; | ||
chainId: CaipChainId; | ||
// Variant of block explorer URLs for non-EVM. | ||
blockExplorerFormatUrls?: MultichainBlockExplorerFormatUrls; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Format" vs "Template"?
Builds ready [67e8cd8]
Page Load Metrics (1761 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current URLs that we use for non-EVM networks does not scale well. The
address
will not always be appended at the end of the URL.Instead, we now use "sort-of" format strings to be able to place the
address
wherever we want on the URL.Also, since we're going to use block explorers to also link transactions, we now use an object that holds multiple format URL instead of just having a single one, see:
Related issues
N/A
Manual testing steps
TODO
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist