Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip type imports when checking circular dependencies #30080

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Feb 3, 2025

Skip type imports when checking circular dependencies.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 3, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [cc8423c]
Page Load Metrics (1814 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15712121181914469
domContentLoaded15582068178413665
load15682121181414871
domInteractive28121482512
backgroundConnect1081322311
firstReactRender1698412713
getState491172210
initialActions01000
loadScripts11041557131613163
setupStore764242110
uiStartup17532563209819694
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

dbrans
dbrans previously approved these changes Feb 4, 2025
Copy link
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

development/circular-deps.ts Outdated Show resolved Hide resolved
HowardBraham
HowardBraham previously approved these changes Feb 4, 2025
@davidmurdoch davidmurdoch dismissed stale reviews from HowardBraham and dbrans via a3303fc February 4, 2025 21:11
@davidmurdoch davidmurdoch marked this pull request as ready for review February 4, 2025 21:12
@davidmurdoch davidmurdoch requested a review from a team as a code owner February 4, 2025 21:12
HowardBraham
HowardBraham previously approved these changes Feb 4, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [3d4324d]
Page Load Metrics (1731 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14112249173319292
domContentLoaded14022189169817885
load14112208173118388
domInteractive238540209
backgroundConnect1090362612
firstReactRender1572342210
getState465222110
initialActions01000
loadScripts10041684124015474
setupStore785202010
uiStartup163825261985230110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

dbrans
dbrans previously approved these changes Feb 4, 2025
@davidmurdoch davidmurdoch dismissed stale reviews from dbrans and HowardBraham via 92f634f February 5, 2025 00:36
@metamaskbot
Copy link
Collaborator

Builds ready [92f634f]
Page Load Metrics (1826 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31723661764386186
domContentLoaded15262274179319292
load15402375182620799
domInteractive2692462110
backgroundConnect11103382914
firstReactRender1599443015
getState591252612
initialActions01000
loadScripts10891704132316177
setupStore864242211
uiStartup174932002151361173
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 6332ad8 Feb 6, 2025
72 checks passed
@davidmurdoch davidmurdoch deleted the fix-circle-thing branch February 6, 2025 19:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants