Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cp-12.10.4 transaction resubmit on multiple endpoints #30079

Merged

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Feb 3, 2025

Description

Upgrade @metamask/transaction-controller to prevent transactions being resubmit on multiple endpoints.

Open in GitHub Codespaces

Related issues

Fixes: #30061

Manual testing steps

  1. Add additional endpoint for network.
  2. Open Network tab of developer console.
  3. Select first endpoint.
  4. Send transaction.
  5. Verify all RPC requests are to the correct endpoint.
  6. Select second endpoint.
  7. Send transaction.
  8. Verify all RPC requests are to the correct endpoint.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 3, 2025
Copy link

socket-security bot commented Feb 3, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 2.18 MB metamaskbot

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [2bb54b6]
Page Load Metrics (1833 ± 103 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36223851706487234
domContentLoaded149322351804212102
load153822541833215103
domInteractive23126442311
backgroundConnect971332110
firstReactRender1599372713
getState4109303215
initialActions01000
loadScripts10661666133017785
setupStore761222010
uiStartup174228282139331159
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 261 Bytes (0.00%)

@sleepytanya
Copy link
Contributor

All RPC requests sent to the correct endpoint:

fix.mov

OGPoyraz
OGPoyraz previously approved these changes Feb 4, 2025
package.json Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [e34b703]
Page Load Metrics (1594 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27319111382448215
domContentLoaded13922078157716680
load14022083159416479
domInteractive2394352211
backgroundConnect85326168
firstReactRender1587332512
getState510611
initialActions00000
loadScripts9831571114213665
setupStore66016189
uiStartup15662276180617685
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 261 Bytes (0.00%)

@heypran
Copy link

heypran commented Feb 4, 2025

Awesome!!! Thanks

@itsyoboieltr itsyoboieltr added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@itsyoboieltr itsyoboieltr changed the title fix: transaction resubmit on multiple endpoints fix (cp-12.10.4): transaction resubmit on multiple endpoints Feb 4, 2025
@itsyoboieltr itsyoboieltr changed the title fix (cp-12.10.4): transaction resubmit on multiple endpoints fix: cp-12.10.4 transaction resubmit on multiple endpoints Feb 4, 2025
@itsyoboieltr itsyoboieltr added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit a381650 Feb 4, 2025
76 of 77 checks passed
@itsyoboieltr itsyoboieltr deleted the fix/30061-transaction-resubmit-multiple-endpoints branch February 4, 2025 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-confirmations Push issues to confirmations team
Projects
None yet
9 participants