-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cp-12.10.4 transaction resubmit on multiple endpoints #30079
Merged
itsyoboieltr
merged 2 commits into
main
from
fix/30061-transaction-resubmit-multiple-endpoints
Feb 4, 2025
Merged
fix: cp-12.10.4 transaction resubmit on multiple endpoints #30079
itsyoboieltr
merged 2 commits into
main
from
fix/30061-transaction-resubmit-multiple-endpoints
Feb 4, 2025
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
7 tasks
Builds ready [2bb54b6]
Page Load Metrics (1833 ± 103 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
All RPC requests sent to the correct endpoint: fix.mov |
OGPoyraz
previously approved these changes
Feb 4, 2025
pedronfigueiredo
previously approved these changes
Feb 4, 2025
e34b703
hmalik88
reviewed
Feb 4, 2025
Builds ready [e34b703]
Page Load Metrics (1594 ± 79 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jpuri
approved these changes
Feb 4, 2025
Awesome!!! Thanks |
OGPoyraz
approved these changes
Feb 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
release-12.13.0
Issue or pull request that will be included in release 12.13.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade
@metamask/transaction-controller
to prevent transactions being resubmit on multiple endpoints.Related issues
Fixes: #30061
Manual testing steps
Network
tab of developer console.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist