fix: eth_accounts / accountsChanged behavior when wallet is locked

[ffmcgee725]

Description

Refer to [#3853](https://github.com/MetaMask/MetaMask-planning/issues/3853)

-->

Related issues

Fixes:

Manual testing steps

1. Go to this page
2. Open dev tools
3. Enter await window.ethereum.on('accountsChanged', console.log) on console
4. Lock / unlock wallet and make sure event is not emitted

Screenshots/Recordings

Before

After

Screen.Recording.2025-02-03.at.15.44.50.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [5e5f41e]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1709 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1489	2001	1710	144	69
		domContentLoaded	1477	1978	1680	136	65
		load	1491	1990	1709	143	68
		domInteractive	26	91	45	23	11
		backgroundConnect	11	72	30	21	10
		firstReactRender	16	89	33	25	12
		getState	5	73	16	19	9
		initialActions	0	1	0	0	0
		loadScripts	1036	1428	1220	117	56
		setupStore	8	91	28	26	13
		uiStartup	1721	2630	1990	210	101

Bundle size diffs [🚀 Bundle size reduced!]

• background: -89 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[jiexi]

this change is breaking and will result in unintended behavior. We still need to return empty array for accounts in this hook when the wallet is locked

[ffmcgee725]

@adonesky1 can you chime in here ?

[metamaskbot]

Builds ready [5e5f41e]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1709 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1489	2001	1710	144	69
		domContentLoaded	1477	1978	1680	136	65
		load	1491	1990	1709	143	68
		domInteractive	26	91	45	23	11
		backgroundConnect	11	72	30	21	10
		firstReactRender	16	89	33	25	12
		getState	5	73	16	19	9
		initialActions	0	1	0	0	0
		loadScripts	1036	1428	1220	117	56
		setupStore	8	91	28	26	13
		uiStartup	1721	2630	1990	210	101

Bundle size diffs [🚀 Bundle size reduced!]

• background: -89 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [418f591]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1605 ± 60 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1454	1910	1607	123	59
		domContentLoaded	1415	1887	1584	119	57
		load	1453	1957	1605	126	60
		domInteractive	24	124	41	30	14
		backgroundConnect	9	78	25	19	9
		firstReactRender	14	89	40	28	13
		getState	4	51	11	13	6
		initialActions	0	1	0	0	0
		loadScripts	960	1395	1137	119	57
		setupStore	6	56	15	16	8
		uiStartup	1642	2118	1855	144	69

Bundle size diffs [🚀 Bundle size reduced!]

• background: -89 Bytes (-0.00%)
• ui: -367 Bytes (-0.00%)
• common: 0 Bytes (0.00%)

[ffmcgee725]

closed, as #29936 supersedes this work