Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump Snaps packages #30062

Merged
merged 7 commits into from
Feb 4, 2025
Merged

chore: Bump Snaps packages #30062

merged 7 commits into from
Feb 4, 2025

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 3, 2025 •
edited
Loading

Description

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:

  • Add support for onProtocolRequest + the endowment:protocol permission
  • Add URLSearchParams as a default global
  • Add disabled states for all input components

Open in GitHub Codespaces

Related issues

Closes #29669

@metamaskbot metamaskbot added team-snaps-platform Snaps Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 3, 2025
@socket-security Socket Security
Copy link

socket-security bot commented Feb 3, 2025 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 1.81 MB metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 5.62 MB metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 1.56 MB metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 1.52 MB metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 1.39 MB metamaskbot

View full report↗︎

@Mrtenz Mrtenz mentioned this pull request Feb 3, 2025
Draft
7 tasks
@metamaskbot
Copy link
Collaborator

Builds ready [3ab6beb]
Page Load Metrics (1709 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15062241170917182
domContentLoaded14732229168416981
load15062295170918388
domInteractive23116412412
backgroundConnect117726189
firstReactRender1593422512
getState459202010
initialActions00000
loadScripts10451700121515273
setupStore883192311
uiStartup168927851989267128
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 6.05 KiB (0.10%)
  • ui: 226 Bytes (0.00%)
  • common: 4.45 KiB (0.05%)

FrederikBolding and others added 2 commits February 3, 2025 16:59
@FrederikBolding
Update copy
d53d2a3
@david0xd
feat(snaps):Add disabled state for Snap UI interactive components (#2…
7aac0a3 
…9896)

## **Description**
This PR integrates new Snaps UI feature for disabling interactive UI
components.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29896?quickstart=1)

## **Related issues**
Fixes: #29669

## **Related Pull Requests**
MetaMask/snaps#3030

## **Manual testing steps**
1. Make new Snap with custom UI using interactive UI components
specified in the task linked under "related issues".
2. Add flag `disabled={true}` to these components.
3. Check that components with `disabled` flag are not clickable and
their styling is different (opacity 0.5).

## **Screenshots/Recordings**
### **Before**
`disabled` state was not available before, nothing to show here.

### **After**
![Screenshot 2025-01-24 at 16 35
56](https://github.com/user-attachments/assets/b7f55722-9865-4ec6-8069-6dfb2c13b354)


https://github.com/user-attachments/assets/5c8a0404-a7d6-49f1-8e8d-041daaa3b09b

## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@FrederikBolding FrederikBolding marked this pull request as ready for review February 3, 2025 16:03
@FrederikBolding FrederikBolding requested a review from a team as a code owner February 3, 2025 16:03
@metamaskbot
Copy link
Collaborator

Builds ready [7aac0a3]
Page Load Metrics (1721 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15241923171911656
domContentLoaded15151916169511857
load15241921172111656
domInteractive2590432311
backgroundConnect97230209
firstReactRender1596422713
getState45412136
initialActions01000
loadScripts10331408122310751
setupStore85817168
uiStartup17782402197415374
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 6.05 KiB (0.10%)
  • ui: 1.03 KiB (0.01%)
  • common: 4.83 KiB (0.05%)

@metamaskbot
Copy link
Collaborator

Builds ready [dfd3027]
Page Load Metrics (1758 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29122441691363175
domContentLoaded15152216172916579
load15292250175817684
domInteractive228235147
backgroundConnect86527189
firstReactRender16100442914
getState45720209
initialActions01000
loadScripts10571577125412761
setupStore893262512
uiStartup177525182062227109
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 6.05 KiB (0.10%)
  • ui: 1.03 KiB (0.01%)
  • common: 4.83 KiB (0.05%)

@FrederikBolding FrederikBolding added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 7f746e9 Feb 4, 2025
71 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v87 branch February 4, 2025 12:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@david0xd david0xd david0xd approved these changes

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-snaps-platform Snaps Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a disabled state to all of our interactive components
4 participants
@FrederikBolding @metamaskbot @Mrtenz @david0xd