Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove metametrics circular dependency #30037

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Jan 31, 2025

This PR solves an issue with circular dependencies. It does not change the behavior of the application. It only rearranges functions/files to avoid circular references.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Jan 31, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [b9b7b66]
Page Load Metrics (1625 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14751907163312158
domContentLoaded14511890160711856
load14671905162511857
domInteractive238040209
backgroundConnect105720147
firstReactRender1699542713
getState575202412
initialActions01000
loadScripts10341448118310651
setupStore613921
uiStartup167424811901244117
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [84eb734]
Page Load Metrics (1784 ± 106 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint54521741688297143
domContentLoaded153825121759224108
load155025161784221106
domInteractive2697412110
backgroundConnect1071282110
firstReactRender1596482914
getState55616157
initialActions01000
loadScripts11211954128819694
setupStore86016157
uiStartup176726892069266128
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [3fa5a9c]
Page Load Metrics (1736 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27820761654349168
domContentLoaded14682061170515172
load14872079173615373
domInteractive247934136
backgroundConnect115729178
firstReactRender15100422813
getState45412136
initialActions01000
loadScripts10441475123711455
setupStore786212211
uiStartup173826162006224108
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [fd717cc]
Page Load Metrics (1726 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15072184172716378
domContentLoaded14902099169613967
load15042191172616479
domInteractive249134178
backgroundConnect10127323014
firstReactRender1593352512
getState46017199
initialActions01000
loadScripts10401492122911053
setupStore86121209
uiStartup17232535198820799
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch changed the base branch from main to fix-circle-thing February 5, 2025 22:57
Base automatically changed from fix-circle-thing to main February 6, 2025 19:44
@davidmurdoch davidmurdoch marked this pull request as ready for review February 6, 2025 22:00
@davidmurdoch davidmurdoch requested review from a team, HowardBraham and dbrans as code owners February 6, 2025 22:00
HowardBraham
HowardBraham previously approved these changes Feb 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [8672b48]
Page Load Metrics (1732 ± 115 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint141022211735243117
domContentLoaded140322131714234112
load141122221732239115
domInteractive22100432411
backgroundConnect97223199
firstReactRender1582362512
getState462242311
initialActions00000
loadScripts9911729122317986
setupStore76314147
uiStartup161825151982269129
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-extension-platform Extension Platform team
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

3 participants