-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(snaps):Add disabled state for Snap UI interactive components #29896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
51c347b
to
6c745ce
Compare
Builds ready [6c745ce]
Page Load Metrics (1858 ± 84 ms)
Bundle size diffs
|
Builds ready [662cbbf]
Page Load Metrics (1684 ± 90 ms)
Bundle size diffs
|
david0xd
added a commit
to MetaMask/snaps
that referenced
this pull request
Jan 28, 2025
Add `disabled` state to all input-related Snaps UI components. Related task: MetaMask/metamask-extension#29669 Extension integration PR: MetaMask/metamask-extension#29896  https://github.com/user-attachments/assets/cb9eee52-31d6-4b3b-b83d-ac4ba136a2d8
662cbbf
to
9d5a44f
Compare
9d5a44f
to
0c64a8a
Compare
ui/components/app/snaps/snap-ui-radio-group/snap-ui-radio-group.tsx
Outdated
Show resolved
Hide resolved
Builds ready [0c64a8a]
Page Load Metrics (1661 ± 68 ms)
|
FrederikBolding
approved these changes
Feb 3, 2025
7b13847
to
fa75db1
Compare
Builds ready [3059e34]
Page Load Metrics (2615 ± 275 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates new Snaps UI feature for disabling interactive UI components.
Related issues
Fixes: #29669
Related Pull Requests
MetaMask/snaps#3030
Manual testing steps
disabled={true}
to these components.disabled
flag are not clickable and their styling is different (opacity 0.5).Screenshots/Recordings
Before
disabled
state was not available before, nothing to show here.After
Screen.Recording.2025-01-24.at.16.53.37.mov
Pre-merge author checklist
Pre-merge reviewer checklist