feat: SIP-26 Integration #29887

jiexi · 2025-01-23T23:09:16Z

General Testing:

Run this in a flask build
Create Solana Accounts
Go to the Multichain Test Dapp (which now supports Solana!):

Screen.Recording.2025-04-03.at.5.00.51.PM.mov

Related issues

Ticket: https://github.com/orgs/MetaMask/projects/146/views/6?pane=issue&itemId=94617458&issue=MetaMask%7CMetaMask-planning%7C3989
Upstream Extension: #27782
Core: MetaMask/core#5191

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** This link was pointing to a dead site, this fixes it to point to the correct URL. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29733?quickstart=1) ## **Related issues** N/A ## **Manual testing steps** 1. Go to https://github.com/MetaMask/metamask-extension/blob/develop/docs/README.md 2. Click the link to Developer Docs ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-23T23:09:28Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jiexi · 2025-02-05T21:47:40Z

@metamaskbot update-policies

metamaskbot · 2025-02-05T22:00:08Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

socket-security · 2025-02-11T10:57:58Z

All alerts resolved. Learn more about Socket for GitHub ↗

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report ↗

jiexi · 2025-02-11T17:06:25Z

@metamaskbot update-policies

metamaskbot · 2025-02-11T17:19:14Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-02-11T17:31:33Z

❌ API Spec Test Failed. View the report here.

metamaskbot · 2025-02-11T17:31:52Z

❌ Multichain API Spec Test Failed. View the report here.

metamaskbot · 2025-02-12T14:14:25Z

❌ API Spec Test Failed. View the report here.

metamaskbot · 2025-02-12T14:15:11Z

❌ Multichain API Spec Test Failed. View the report here.

mcmire · 2025-03-06T15:56:18Z

A couple of notes:

The Bitcoin integration was disabled in chore(bitcoin): add bitcoin build feature + disable it temporarily #30477, so we have to use the Solana integration for testing. I think this could work:

const extensionPort = chrome.runtime.connect(YOUR_EXTENSION_ID)

extensionPort.onMessage.addListener((msg) => {
  console.log(msg.data)
})

extensionPort.postMessage({
  type: "caip-x",
  data: {
    jsonrpc: "2.0",
    method: "wallet_createSession",
    params: {
      requiredScopes: {},
      optionalScopes: {
        "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp": {
          methods: ["getAccount"],
          notifications: [],
          accounts: []
        }
      },
    },
  }
})

extensionPort.postMessage({
  type: "caip-x",
  data: {
    jsonrpc: "2.0",
    method: "wallet_invokeMethod",
    params: {
      scope: "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
      request: {
        method: "getAccount",
        params: [YOUR_SOLANA_ACCOUNT_ID]
      }
    }
  }
})

However, the above does not work, and in fact, the new changes introduced in this PR are breaking createSession, getSession, etc. I'm not sure why, I'll have to investigate.

socket-security · 2025-03-06T20:49:48Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub ↗.

Package	Supply Chain Security	Quality	Maintenance
@metamask/[email protected]
[email protected] ⏵ 1.0.30001669
@metamask/[email protected]
@metamask/[email protected] ⏵ 10.1.0	^-10	⁺¹	⁺³

View full report ↗

metamaskbot · 2025-03-07T19:28:12Z

Builds ready [552e273]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1671 ± 105 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1533	2339	1676	218	104
		domContentLoaded	1508	2290	1645	216	104
		load	1532	2347	1671	219	105
		domInteractive	25	95	39	18	9
		backgroundConnect	12	62	32	15	7
		firstReactRender	14	65	34	22	11
		getState	5	47	10	9	4
		initialActions	0	1	0	0	0
		loadScripts	1082	1805	1226	195	94
		setupStore	7	12	8	1	1
		uiStartup	1697	2545	1880	215	103

metamaskbot · 2025-03-07T22:25:12Z

Builds ready [c6b5bc7]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1912 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	398	2150	1749	459	221
		domContentLoaded	1723	2086	1850	107	52
		load	1751	2190	1912	129	62
		domInteractive	25	75	36	14	7
		backgroundConnect	13	191	63	58	28
		firstReactRender	16	73	38	22	11
		getState	6	141	39	41	20
		initialActions	0	1	0	0	0
		loadScripts	1295	1591	1398	82	39
		setupStore	8	60	29	20	10
		uiStartup	2012	3184	2326	359	172

adonesky1 · 2025-03-12T20:54:20Z

Per @mcmire 's comment above

The Bitcoin integration was disabled in #30477, so we have to use the Solana integration for testing:

In order to test with solana you will need to:

build this branch on flask
create a solana account
The script below will work to create a session/connection with a site and the wallet including Solana. The connection flow is not yet wired up to show Solana accounts, but you can connect for read only purposes.

const extensionPort = chrome.runtime.connect(YOUR_EXTENSION_ID)

extensionPort.onMessage.addListener((msg) => {
  console.log(msg.data)
})

extensionPort.postMessage({
  type: "caip-x",
  data: {
    jsonrpc: "2.0",
    method: "wallet_createSession",
    params: {
      requiredScopes: {},
      optionalScopes: {
        "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp": {
          methods: ["getAccount"],
          notifications: [],
          accounts: []
        }
      },
    },
  }
})

The Solana snap is currently broken but a fix was recently merged and should be released and merged to main soon.
Once that fix is added and absorbed into this branch you'll be able to call to the Solana snap with this script:

extensionPort.postMessage({
  type: "caip-x",
  data: {
    jsonrpc: "2.0",
    method: "wallet_invokeMethod",
    params: {
      scope: "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
      request: {
        method: "getGenesisHash",
        params: []
      }
    }
  }

metamaskbot · 2025-03-12T21:05:50Z

Builds ready [547fb5d]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1874 ± 126 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1566	2439	1852	220	106
		domContentLoaded	1557	2159	1755	148	71
		load	1567	2660	1874	262	126
		domInteractive	23	113	33	20	9
		backgroundConnect	13	592	114	132	64
		firstReactRender	14	88	36	21	10
		getState	5	220	48	58	28
		initialActions	0	1	0	0	0
		loadScripts	1163	1610	1330	104	50
		setupStore	7	64	19	17	8
		uiStartup	1783	4295	2338	619	297

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.4 KiB (0.02%)
ui: 158 Bytes (0.00%)
common: 9.53 KiB (0.09%)

metamaskbot · 2025-03-18T15:22:51Z

Builds ready [21627b6]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1751 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	236	2171	1657	360	173
		domContentLoaded	1513	1991	1691	133	64
		load	1528	2293	1751	177	85
		domInteractive	22	90	35	15	7
		backgroundConnect	9	356	63	77	37
		firstReactRender	17	85	46	21	10
		getState	4	198	25	43	21
		initialActions	0	1	0	0	0
		loadScripts	1087	1508	1248	113	54
		setupStore	8	70	25	23	11
		uiStartup	1788	3628	2094	401	192

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.4 KiB (0.02%)
ui: 158 Bytes (0.00%)
common: 9.53 KiB (0.09%)

app/scripts/lib/rpc-method-middleware/handlers/wallet-createSession/handler.ts

## **Description**  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31736?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@FrederikBolding

Attempt to address [some concerns about time complexity raised by @FrederikBolding](#29887 (comment)) rename and reorganize these helpers for easier navigation. I have [an open PR against core here](MetaMask/core#5609) where I've made the improvements + name changes that can be reviewed and merged immediately after 12.17.0 cut

FrederikBolding · 2025-04-09T17:58:43Z

ui/pages/permissions-connect/connect-page/connect-page.tsx

+  const supportedRequestedAccounts = requestedCaipAccountIds.reduce(
+    (acc, account) => {
+      const supportedRequestedAccount =
+        supportedAccountsForRequestedNamespaces.find(


Could these be EIP155 addresses that should be compared without casing? Just wondering if this might cause a bug in the EVM flow

Yeah I considered this and thought it wasn't an issue, but I think it may be so I'll add that check for EVM addresses only

The consequences here are pretty low, it would just mean a requested account (rare that specific accounts are requested at all) wouldn't get default pre-checked in case mismatch

Yeah, but seems worth it to make sure since we specifically added this for certain dapps that asked for it 😄

Probably not for now, but perhaps worth considering in the future to move some of this to a more shared place. So we don't have multiple implementations of checking for EIP155 etc

done here: bc2852a

mcmire

LGTM!

metamaskbot · 2025-04-09T18:24:24Z

Builds ready [308b7ce]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1219 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1219	1093	1425	70	1262	1368
			load	1067	970	1251	63	1166	994
			domContentLoaded	1062	965	1244	63	1181	992
			domInteractive	17	13	62	7	16	27
			firstPaint	711	135	1248	419	253	984
			backgroundConnect	7	4	21	2	7	9
			firstReactRender	20	14	49	5	20	27
			getState	13	5	34	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	820	732	1014	63	856	941
			setupStore	7	4	18	2	7	8
	Webpack	Home	uiStartup	2151	1739	2765	186	2276	2418
			load	1721	1265	2444	179	1802	1969
			domContentLoaded	1715	1258	2434	178	1798	1962
			domInteractive	18	12	85	13	14	53
			firstPaint	178	69	1837	176	214	88
			backgroundConnect	29	9	242	32	29	56
			firstReactRender	155	53	466	112	60	88
			getState	11	3	35	6	7	8
			initialActions	3	1	7	1	3	5
			loadScripts	1707	1256	2394	175	1793	1952
			setupStore	26	6	299	47	7	9
Firefox	Browserify	Home	uiStartup	1376	1189	1831	118	1435	1644
			load	1233	1058	1710	120	1288	1514
			domContentLoaded	1233	1057	1709	120	1288	1514
			domInteractive	107	38	318	40	92	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	67	7	19	34
			firstReactRender	23	18	50	6	23	32
			getState	9	4	157	16	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1217	1038	1696	120	1276	1498
			setupStore	6	4	33	3	6	7
	Webpack	Home	uiStartup	1526	1377	1964	100	1591	1677
			load	1319	1193	1680	91	1384	1460
			domContentLoaded	1318	1192	1679	91	1384	1459
			domInteractive	96	50	229	25	90	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	46	5	22	34
			firstReactRender	35	29	50	5	37	46
			getState	8	3	45	6	8	9
			initialActions	1	0	2	1	1	1
			loadScripts	1300	1174	1653	90	1362	1443
			setupStore	8	5	29	4	8	9

metamaskbot · 2025-04-09T19:39:52Z

Builds ready [13492c2]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1239	1124	1421	56	1271	1334
			load	1083	973	1199	51	1132	973
			domContentLoaded	1077	969	1182	50	1128	984
			domInteractive	18	13	60	7	17	31
			firstPaint	739	149	1196	427	231	281
			backgroundConnect	7	4	20	2	7	9
			firstReactRender	20	16	47	6	20	36
			getState	14	5	74	9	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	834	739	933	48	870	916
			setupStore	8	5	23	3	7	8
	Webpack	Home	uiStartup	2169	1717	2610	167	2279	2383
			load	1694	1295	2141	154	1765	1980
			domContentLoaded	1687	1288	2135	152	1754	1971
			domInteractive	17	12	70	12	14	55
			firstPaint	155	66	312	51	206	91
			backgroundConnect	33	9	398	44	36	65
			firstReactRender	197	55	491	121	60	86
			getState	19	4	303	38	54	9
			initialActions	3	1	8	1	3	5
			loadScripts	1682	1286	2133	149	1752	1940
			setupStore	26	6	308	46	33	9
Firefox	Browserify	Home	uiStartup	1356	1196	1667	112	1434	1606
			load	1211	1073	1537	109	1275	1435
			domContentLoaded	1211	1073	1536	109	1275	1435
			domInteractive	95	39	201	27	90	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	63	10	20	51
			firstReactRender	23	19	64	6	23	27
			getState	7	3	20	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1192	1056	1517	109	1256	1419
			setupStore	9	3	177	18	6	7
	Webpack	Home	uiStartup	1549	1387	1941	116	1598	1809
			load	1333	1178	1648	105	1381	1556
			domContentLoaded	1332	1177	1648	105	1380	1556
			domInteractive	95	40	318	29	91	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	53	6	23	37
			firstReactRender	36	29	54	5	39	47
			getState	10	4	42	7	8	9
			initialActions	1	0	2	1	1	1
			loadScripts	1313	1159	1626	104	1359	1539
			setupStore	8	5	49	5	8	9

metamaskbot added the team-wallet-api-platform label Jan 23, 2025

jiexi mentioned this pull request Jan 23, 2025

feat: Integrate non-evm SIP-26 support into @metamask/multichain MetaMask/core#5191

Merged

4 tasks

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 24, 2025

Base automatically changed from jl/caip-multichain-migrate-core to main March 11, 2025 20:58

adonesky1 changed the base branch from main to jl/caip-multichain-migrate-core March 12, 2025 18:24

adonesky1 force-pushed the sip-26 branch from c6b5bc7 to 09c96f5 Compare March 12, 2025 19:43

jiexi changed the base branch from jl/caip-multichain-migrate-core to main March 12, 2025 20:24

jiexi changed the title ~~DRAFT: SIP-26 Integration~~ feat: SIP-26 Integration Mar 12, 2025

adonesky1 and others added 4 commits March 19, 2025 11:28

apply sip-26 multichain api changes

d535d0c

remove reject file

e26603e

Bump snaps-controllers

cf37485

repoint @metamask/multichain package references to new packages

840e743

FrederikBolding reviewed Apr 9, 2025

View reviewed changes

app/scripts/lib/rpc-method-middleware/handlers/wallet-createSession/handler.ts Outdated Show resolved Hide resolved

adonesky1 added 2 commits April 9, 2025 10:26

update lavamoat policy files

2e1c2d1

revert promptToCreateSolanaAccount

2199608

adonesky1 force-pushed the sip-26 branch from 8ab2070 to 2199608 Compare April 9, 2025 15:28

adonesky1 and others added 6 commits April 9, 2025 10:55

lint

c971452

Merge branch 'main' into sip-26

8e6d493

add multichain API to beta build

dc2a898

Merge branch 'main' into sip-26

308b7ce

FrederikBolding reviewed Apr 9, 2025

View reviewed changes

add back case insensitive check for eip155 accounts

bc2852a

FrederikBolding previously approved these changes Apr 9, 2025

View reviewed changes

mcmire previously approved these changes Apr 9, 2025

View reviewed changes

darkwing previously approved these changes Apr 9, 2025

View reviewed changes

adonesky1 enabled auto-merge April 9, 2025 18:24

Fix connect page

13492c2

jiexi dismissed stale reviews from darkwing, mcmire, and FrederikBolding via 13492c2 April 9, 2025 18:38

FrederikBolding approved these changes Apr 9, 2025

View reviewed changes

darkwing approved these changes Apr 9, 2025

View reviewed changes

adonesky1 added this pull request to the merge queue Apr 9, 2025

Merged via the queue into main with commit 3ab2865 Apr 9, 2025
165 of 166 checks passed

adonesky1 deleted the sip-26 branch April 9, 2025 20:52

github-actions bot locked and limited conversation to collaborators Apr 9, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: SIP-26 Integration #29887

feat: SIP-26 Integration #29887

jiexi commented Jan 23, 2025 •

edited by adonesky1

Loading

github-actions bot commented Jan 23, 2025

jiexi commented Feb 5, 2025

metamaskbot commented Feb 5, 2025

socket-security bot commented Feb 11, 2025 •

edited

Loading

jiexi commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

mcmire commented Mar 6, 2025 •

edited

Loading

socket-security bot commented Mar 6, 2025 •

edited

Loading

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

adonesky1 commented Mar 12, 2025

metamaskbot commented Mar 12, 2025

metamaskbot commented Mar 18, 2025

FrederikBolding Apr 9, 2025

adonesky1 Apr 9, 2025

adonesky1 Apr 9, 2025

FrederikBolding Apr 9, 2025

FrederikBolding Apr 9, 2025

adonesky1 Apr 9, 2025

mcmire left a comment

metamaskbot commented Apr 9, 2025

metamaskbot commented Apr 9, 2025

feat: SIP-26 Integration #29887

feat: SIP-26 Integration #29887

Conversation

jiexi commented Jan 23, 2025 • edited by adonesky1 Loading

Related issues

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 23, 2025

jiexi commented Feb 5, 2025

metamaskbot commented Feb 5, 2025

socket-security bot commented Feb 11, 2025 • edited Loading

jiexi commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

mcmire commented Mar 6, 2025 • edited Loading

socket-security bot commented Mar 6, 2025 • edited Loading

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

adonesky1 commented Mar 12, 2025

metamaskbot commented Mar 12, 2025

metamaskbot commented Mar 18, 2025

FrederikBolding Apr 9, 2025

Choose a reason for hiding this comment

adonesky1 Apr 9, 2025

Choose a reason for hiding this comment

adonesky1 Apr 9, 2025

Choose a reason for hiding this comment

FrederikBolding Apr 9, 2025

Choose a reason for hiding this comment

FrederikBolding Apr 9, 2025

Choose a reason for hiding this comment

adonesky1 Apr 9, 2025

Choose a reason for hiding this comment

mcmire left a comment

Choose a reason for hiding this comment

metamaskbot commented Apr 9, 2025

metamaskbot commented Apr 9, 2025

jiexi commented Jan 23, 2025 •

edited by adonesky1

Loading

socket-security bot commented Feb 11, 2025 •

edited

Loading

mcmire commented Mar 6, 2025 •

edited

Loading

socket-security bot commented Mar 6, 2025 •

edited

Loading