Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure SRP backup reminder only displays when on HDKey account #29857

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jan 22, 2025

Description

Ensures that the SRP backup reminder only displays if the user is on HD keyring, so will not display if the user is on hardware wallet or imported wallet

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Create a new wallet and do NOT backup SRP
  2. Finish onboarding, see SRP reminder
  3. Import a new account, do NOT see SRP reminder
  4. Add hardware wallet account, do NOT see SRP reminder

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing force-pushed the dismiss-conditions branch from c9af853 to cc439ef Compare March 11, 2025 22:24
@metamaskbot
Copy link
Collaborator

Builds ready [cc439ef]
Page Load Metrics (2033 ± 213 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint40132441848568273
domContentLoaded164226541918236113
load169638212033443213
domInteractive25150453216
backgroundConnect10991105211101
firstReactRender15187423919
getState65385411455
initialActions01000
loadScripts12281744145014971
setupStore8247345325
uiStartup1949950026431600768
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 70 Bytes (0.00%)

@darkwing darkwing added this pull request to the merge queue Mar 14, 2025
Merged via the queue into main with commit b32986d Mar 14, 2025
75 checks passed
@darkwing darkwing deleted the dismiss-conditions branch March 14, 2025 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
@metamaskbot metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.16.0 Issue or pull request that will be included in release 12.16.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants