test: [POM] Migrate connections e2e tests to TS and Page Object Model #29609

chloeYue · 2025-01-09T16:31:16Z

Description

Follow PR #29384 and continue migrating the remaining connection e2e tests to TypeScript and the Page Object Model.

Specs migrated:

test/e2e/tests/connections/review-permissions-page.spec.js
test/e2e/tests/connections/review-switch-permission-page.spec.js
test/e2e/tests/content-security-policy/content-security-policy.spec.js

Related issues

Fixes:

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-09T16:31:29Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-01-09T18:39:52Z

Builds ready [d8189fc]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1777 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	292	2151	1650	462	222
		domContentLoaded	1553	2105	1754	151	72
		load	1564	2138	1777	151	73
		domInteractive	28	87	42	18	9
		backgroundConnect	7	90	27	21	10
		firstReactRender	18	93	51	28	13
		getState	5	62	20	20	10
		initialActions	0	1	0	0	0
		loadScripts	1117	1530	1282	131	63
		setupStore	6	15	9	2	1
		uiStartup	1816	2487	2075	198	95

metamaskbot · 2025-01-14T09:49:12Z

Builds ready [8dc3e3c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1540 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1423	1791	1545	94	45
		domContentLoaded	1406	1779	1520	95	46
		load	1424	1798	1540	99	48
		domInteractive	23	134	40	26	12
		backgroundConnect	7	73	23	18	9
		firstReactRender	15	77	36	24	11
		getState	4	53	12	13	6
		initialActions	0	1	0	0	0
		loadScripts	1027	1335	1131	81	39
		setupStore	6	43	9	8	4
		uiStartup	1607	2034	1740	104	50

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-15T15:46:41Z

Builds ready [fa94554]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1797 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1557	2057	1805	132	64
		domContentLoaded	1505	2007	1765	128	62
		load	1547	2017	1797	126	61
		domInteractive	17	102	40	20	10
		backgroundConnect	10	82	31	22	10
		firstReactRender	19	101	50	26	12
		getState	5	66	21	21	10
		initialActions	0	1	0	0	0
		loadScripts	1107	1513	1318	110	53
		setupStore	7	87	22	25	12
		uiStartup	1780	2640	2166	242	116

Bundle size diffs [🚀 Bundle size reduced!]

background: -104.59 KiB (-1.80%)
ui: 2.88 KiB (0.04%)
common: -34.29 KiB (-0.41%)

metamaskbot · 2025-02-04T03:11:56Z

Builds ready [be2da98]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1807 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	314	2088	1735	352	169
		domContentLoaded	1584	2071	1785	135	65
		load	1598	2078	1807	131	63
		domInteractive	19	86	37	18	8
		backgroundConnect	11	61	25	17	8
		firstReactRender	17	100	36	25	12
		getState	6	50	15	15	7
		initialActions	0	1	0	0	0
		loadScripts	1109	1532	1303	109	53
		setupStore	8	67	31	24	11
		uiStartup	1838	2634	2090	190	91

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

DDDDDanica · 2025-02-04T17:17:36Z

LGTM !

seaona · 2025-02-04T17:18:08Z

test/e2e/page-objects/pages/permission/site-permission-page.ts

+    console.log('Disconnect all permissions for accounts and networks');
+    await this.driver.clickElement(this.disconnectButton);
+    await this.driver.waitForSelector(this.disconnectModalTitle);
+    await this.driver.clickElementAndWaitToDisappear(


more flakiness mitigation, nice 🙌

seaona

Overall looks good! Just added a small nit, let me know if it makes sense!

seaona · 2025-02-04T17:20:36Z

test/e2e/page-objects/pages/test-dapp.ts

@@ -612,13 +612,16 @@ class TestDapp {
   * @param options - Options for connecting account to test dapp.
   * @param [options.connectAccountButtonEnabled] - Indicates if the connect account button should be enabled.
   * @param options.publicAddress - The public address to connect to test dapp.
+   * @param [options.networkId] - The network to connect to, defaults to 0x539.


mm I think we might want to reference the chainId here?

Suggested change

* @param [options.networkId] - The network to connect to, defaults to 0x539.

* @param [options.chainId] - The chain id to connect to, defaults to 0x539.

seaona · 2025-02-04T17:21:00Z

test/e2e/page-objects/pages/test-dapp.ts

   */
  async connectAccount({
    connectAccountButtonEnabled = true,
    publicAddress,
+    networkId = '0x539',


Suggested change

networkId = '0x539',

chainId = '0x539',

seaona · 2025-02-04T17:21:08Z

test/e2e/page-objects/pages/test-dapp.ts

  }: {
    connectAccountButtonEnabled?: boolean;
    publicAddress?: string;
+    networkId?: string;


Suggested change

networkId?: string;

chainId?: string;

seaona · 2025-02-04T17:21:18Z

test/e2e/page-objects/pages/test-dapp.ts

-      await this.driver.waitForSelector(this.localhostNetworkMessage);
+      await this.driver.waitForSelector({
+        css: '#chainId',
+        text: networkId,


Suggested change

text: networkId,

text: chainId,

chloeYue and others added 11 commits December 17, 2024 15:24

migrate tests

9659249

migrate tests

2f4051a

Merge branch 'main' into chloe-connections-tests

04a773b

migrate tests

23af4a0

migrate tests

8d13c65

migrate tests

955d3fe

address comments

2cb64d8

Merge branch 'main' into chloe-connections-tests

9285dba

fix

bcbf4b5

migrate tests

cb0a47e

Merge branch 'main' into chloe-permissions-tests

6c406e2

chloeYue added e2e-test End to end test for the MetaMask extension team-qa QA team labels Jan 9, 2025

chloeYue self-assigned this Jan 9, 2025

chloeYue requested a review from a team January 9, 2025 16:31

metamaskbot added the team-extension-platform label Jan 9, 2025

chloeYue added 2 commits January 9, 2025 18:31

Merge branch 'main' into chloe-permissions-tests

18bc061

fix

d8189fc

chloeYue requested a review from a team as a code owner January 9, 2025 17:56

chloeYue added 2 commits January 14, 2025 10:09

Merge branch 'main' into chloe-permissions-tests

92729da

revert yml change

8dc3e3c

chloeYue changed the title ~~test: permissions tests~~ test: [POM] Migrate connections e2e tests to TS and Page Object Model Jan 14, 2025

migrate test

fa94554

chloeYue requested review from seaona and removed request for a team and seaona January 15, 2025 15:09

chloeYue marked this pull request as draft January 20, 2025 09:01

Merge branch 'main' into chloe-permissions-tests

be2da98

chloeYue marked this pull request as ready for review February 4, 2025 07:12

DDDDDanica approved these changes Feb 4, 2025

View reviewed changes

seaona reviewed Feb 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: [POM] Migrate connections e2e tests to TS and Page Object Model #29609

test: [POM] Migrate connections e2e tests to TS and Page Object Model #29609

chloeYue commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

metamaskbot commented Jan 14, 2025

metamaskbot commented Jan 15, 2025

metamaskbot commented Feb 4, 2025

DDDDDanica commented Feb 4, 2025

seaona Feb 4, 2025

seaona left a comment

seaona Feb 4, 2025

seaona Feb 4, 2025

seaona Feb 4, 2025

seaona Feb 4, 2025

	* @param [options.networkId] - The network to connect to, defaults to 0x539.
	* @param [options.chainId] - The chain id to connect to, defaults to 0x539.

test: [POM] Migrate connections e2e tests to TS and Page Object Model #29609

Are you sure you want to change the base?

test: [POM] Migrate connections e2e tests to TS and Page Object Model #29609

Conversation

chloeYue commented Jan 9, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

metamaskbot commented Jan 14, 2025

metamaskbot commented Jan 15, 2025

metamaskbot commented Feb 4, 2025

DDDDDanica commented Feb 4, 2025

seaona Feb 4, 2025

Choose a reason for hiding this comment

seaona left a comment

Choose a reason for hiding this comment

seaona Feb 4, 2025

Choose a reason for hiding this comment

seaona Feb 4, 2025

Choose a reason for hiding this comment

seaona Feb 4, 2025

Choose a reason for hiding this comment

seaona Feb 4, 2025

Choose a reason for hiding this comment

chloeYue commented Jan 9, 2025 •

edited

Loading