webpack: legobeat develop branch #18042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm-loader to removeFencedCode
I am not sure what the intention and direction is here. Getting the
following error without reverting:
```
$ yarn build dist
Running task "dist"...
Starting 'dist'...
Starting 'clean'...
Finished 'clean'
Starting 'styles:prod'...
LavaMoat: ignoring write attempt to read-access global "process"
LavaMoat: ignoring write attempt to read-access global "__dirname"
LavaMoat: ignoring write attempt to read-access global "__filename"
LavaMoat: ignoring write attempt to read-access global "Buffer"
[Error: Missing error message
at new PluginError (/app/node_modules/plugin-error/index.js:64:11)
at errorM (/app/node_modules/gulp-dart-sass/index.js:123:15)
at callback (/app/node_modules/gulp-dart-sass/index.js:132:16)
at eval (/app/node_modules/sass/sass.dart.js:22:46)
at Function.call$2 (/app/node_modules/sass/sass.dart.js:93648:16)
at _render_closure1.call$2 (/app/node_modules/sass/sass.dart.js:82008:12)
at _RootZone.runBinary$3$3 (/app/node_modules/sass/sass.dart.js:27548:18)
at _FutureListener.handleError$1 (/app/node_modules/sass/sass.dart.js:26097:19)
at _Future__propagateToListeners_handleError.call$0 (/app/node_modules/sass/sass.dart.js:26395:49)
at Object._Future__propagateToListeners (/app/node_modules/sass/sass.dart.js:4548:77)] {
dartException: <ref *1> {
'$cachedTrace': _StackTrace {
_exception: [Circular *1],
_trace: 'Error: Missing error message\n' +
' at new PluginError (/app/node_modules/plugin-error/index.js:64:11)\n' +
' at errorM (/app/node_modules/gulp-dart-sass/index.js:123:15)\n' +
' at callback (/app/node_modules/gulp-dart-sass/index.js:132:16)\n' +
' at eval (/app/node_modules/sass/sass.dart.js:22:46)\n' +
' at Function.call$2 (/app/node_modules/sass/sass.dart.js:93648:16)\n' +
' at _render_closure1.call$2 (/app/node_modules/sass/sass.dart.js:82008:12)\n' +
' at _RootZone.runBinary$3$3 (/app/node_modules/sass/sass.dart.js:27548:18)\n' +
' at _FutureListener.handleError$1 (/app/node_modules/sass/sass.dart.js:26097:19)\n' +
' at _Future__propagateToListeners_handleError.call$0 (/app/node_modules/sass/sass.dart.js:26395:49)\n' +
' at Object._Future__propagateToListeners (/app/node_modules/sass/sass.dart.js:4548:77)'
}
}
}
```
MetaMask#17872 (review)
Motivation: Make this function reusable for webpack without needing to solve for the livereload interface
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Socket Security Pull Request ReportDependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
eventually we can prob use ts-loader or sth
|
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: opened as requested by @brad-decker
Based on #17872