Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSR] Updated Avatar to use shared types and add hasBorder and hasSolidBackgroundColor #507

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Mar 25, 2025

Description

This PR updates all Avatar-related components to

  • use shared types
  • have 2 additional props hasBorder and hasSolidBackgroundColor

Related issues

Fixes: #509

Manual testing steps

  1. Run yarn storybook from root

Screenshots/Recordings

Before

After

Screen.Recording.2025-03-25.at.10.05.52.AM.mov

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen requested a review from a team as a code owner March 25, 2025 16:09
@brianacnguyen brianacnguyen marked this pull request as draft March 25, 2025 16:10
@brianacnguyen brianacnguyen self-assigned this Mar 25, 2025
@brianacnguyen brianacnguyen marked this pull request as ready for review March 25, 2025 17:23
@brianacnguyen brianacnguyen changed the title Draft: Dsr/avatar update [DSR] Updated Avatar to use shared types and add hasBorder and hasSolidBackgroundColor Mar 25, 2025
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these changes. With the latest decision to keep background-muted opaque, it seems like these updates might no longer be needed. Do you think we should close this PR, or is there still a case for keeping it open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Avatar-related components with shared props and additional props hasBorder and hasSolidBackgroundColor
2 participants