-
-
Notifications
You must be signed in to change notification settings - Fork 79
Move SCL Linked Lib to Embedded #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hanzel98
wants to merge
1
commit into
main
Choose a base branch
from
chore/link-to-embedded-scl-library
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /** | ||
| * | ||
| */ | ||
| /* | ||
| /* ╔═╗╔╦╗╔═╗╔═╗╔╦╗╦ ╦ ╔═╗╦═╗╦ ╦╔═╗╔╦╗╔═╗╦ ╦╔╗ | ||
| /* ╚═╗║║║║ ║║ ║ ║ ╠═╣ ║ ╠╦╝╚╦╝╠═╝ ║ ║ ║║ ║╠╩╗ | ||
| /* ╚═╝╩ ╩╚═╝╚═╝o╩ ╩ ╩ ╚═╝╩╚═ ╩ ╩ ╩ ╚═╝╩═╝╩╚═╝ | ||
| /* | ||
| /* Copyright (C) 2024 - Renaud Dubois - This file is part of SCL (Smoo.th CryptoLib) project | ||
| /* License: This software is licensed under MIT License (and allways will) | ||
| /* Description: This file implements the ecdsa verification protocol using Shamir's trick + 4bit windowing. | ||
| /********************************************************************************************/ | ||
| // SPDX-License-Identifier: MIT | ||
| pragma solidity >=0.8.19 <0.9.0; | ||
|
|
||
| import { a, b, p, gx, gy, n } from "@SCL/fields/SCL_secp256r1.sol"; | ||
|
|
||
| //import modular inversion over prime field defined over curve subgroup of prime order | ||
| import { nModInv } from "@SCL/modular/SCL_modular.sol"; | ||
| //import point on curve checking | ||
| import { ec_isOnCurve } from "@SCL/elliptic/SCL_ecOncurve.sol"; | ||
| //import point double multiplication and accumulation (RIP7696) | ||
| import "@SCL/elliptic/SCL_mulmuladdX_fullgenW.sol"; | ||
|
|
||
| library SCL_RIP7212 { | ||
| function verify(bytes32 message, uint256 r, uint256 s, uint256 qx, uint256 qy) internal view returns (bool) { | ||
| // check the validity of the signature | ||
| if (r == 0 || r >= n || s == 0 || s >= n) { | ||
| return false; | ||
| } | ||
|
|
||
| // check the public key validity (rejecting not on curve and weak keys) | ||
| if (ec_isOnCurve(p, a, b, qx, qy) == false) { | ||
| return false; | ||
| } | ||
|
|
||
| // calculate the scalars used for the multiplication of the point | ||
| uint256 sInv = nModInv(s); | ||
| uint256 scalar_u = mulmod(uint256(message), sInv, n); | ||
| uint256 scalar_v = mulmod(r, sInv, n); | ||
| uint256[6] memory Qpa = [qx, qy, p, a, gx, gy]; | ||
|
|
||
| uint256 x1; | ||
| (x1,) = ecGenMulmuladdB4W(Qpa, scalar_u, scalar_v); | ||
|
|
||
| assembly { | ||
| x1 := addmod(x1, sub(n, r), n) | ||
| } | ||
|
|
||
| return x1 == 0; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'd add a comment in the code itself about why we've copied it to this repo and the changes made