feat: assets-controllers extract and export getAssetId#9386
Open
maxime-oe wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| */ | ||
| const chainIdToNativeTokenAddress: Record<Hex, Hex> = { | ||
| '0x89': '0x0000000000000000000000000000000000001010', // Polygon | ||
| '0x1e': '0x542fda317318ebf1d3deaf76e0b632741a7e677d', // Rootstock Mainnet - Native symbol: RBTC |
There was a problem hiding this comment.
Rootstock native address mapping removed
Medium Severity
The Rootstock (0x1e) entry was removed from chainIdToNativeTokenAddress, so getNativeTokenAddress now returns the zero address instead of RBTC’s contract address. Native detection in getAssetId and market-data keys in TokenRatesController no longer match wallets that still use the RBTC address, which can misclassify native RBTC as ERC-20 or drop prices.
Reviewed by Cursor Bugbot for commit 99313eb. Configure here.
Contributor
Author
There was a problem hiding this comment.
0x542fda317318ebf1d3deaf76e0b632741a7e677d has never been the native.
maxime-oe
force-pushed
the
feat/assets-controllers-extract-getassetid
branch
from
99313eb to
734dfcf
Compare
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
maxime-oe
force-pushed
the
feat/assets-controllers-extract-getassetid
branch
from
c152079 to
c6bc289
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Extract
getAssetIdfrom thefetchTokenPricesso it can be reused later not only for v3 Spot Prices but also V3 historical prices.Extension draft client: MetaMask/metamask-extension#44161
Mobile draft client: MetaMask/metamask-mobile#32796
Added
getAssetIdincodefi-v2.tsfor CAIP-19 asset ID derivation - extracted from existingfetchTokenPrices(#9386)Changed
988), Rootstock (30) and Gnosis (100) incodefi-v2.ts(#9386)References
Checklist
Note
Medium Risk
Changes how native tokens on Gnosis, Stable, and related chains map to Price API asset IDs, which can alter spot price lookups for those assets until verified against the v3 API.
Overview
Extracts CAIP-19 asset ID derivation from
CodefiTokenPricesServiceV2spot-price fetching into a shared, exportedgetAssetIdhelper (ERC-20 paths, native tokens viaSPOT_PRICES_SUPPORT_INFOornativeAssetIdentifiers, safe handling of bad input).fetchTokenPricesnow calls that helper instead of inlined logic so clients can reuse the same mapping for other Price API flows (e.g. historical prices).Native price identifiers are updated in
codefi-v2.ts: Gnosis (100) and Stable (988) native assets now use the zero-addresserc20CAIP-19 form instead of chain-specific contract IDs, and Rootstock, Gnosis, and Stable are dropped from the customchainIdToNativeTokenAddressmap so native detection follows the default zero address. Unit tests covergetAssetIdbehavior and package exports include the new symbol.Reviewed by Cursor Bugbot for commit 486a2d1. Bugbot is set up for automated code reviews on this repo. Configure here.