Skip to content

Normalizes fourByte data in method selector #6102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Normalizes fourByte data in method selector #6102

wants to merge 5 commits into from
+55 −93

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Jul 10, 2025 •
edited
Loading

Explanation

This PR updates the getMethodName utility to normalise the transaction data to lowercase before comparing it against known ABI method selectors.

References

Fixes https://github.com/MetaMask/MetaMask-planning/issues/5338

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@vinistevam vinistevam marked this pull request as ready for review July 10, 2025 16:11
@vinistevam vinistevam requested review from a team as code owners July 10, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpuri jpuri jpuri approved these changes

Assignees
No one assigned
Labels
team-confirmations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistevam @jpuri