Skip to content

feat: scanUrl dedupe logic and flag for cache/in-flight requests only #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

imblue-dabadee
Copy link
Contributor

@imblue-dabadee imblue-dabadee commented Jun 25, 2025

Explanation

This introduces deduplication logic for scanUrl so that multiple callers do not create multiple in-flight requests for the same URL. It also introduces a flag to only return resolved scans within the cache OR return promises for in-flight requests s.t. it does not create new outbound requests.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@imblue-dabadee imblue-dabadee changed the title feat: scanUrl dedupe logic and flag for cache/in-flight requests only feat: scanUrl dedupe logic and flag for cache/in-flight requests only Jun 25, 2025
@imblue-dabadee imblue-dabadee marked this pull request as ready for review June 25, 2025 14:12
@imblue-dabadee imblue-dabadee requested review from a team as code owners June 25, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant