temp req - closing - #1929
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
…id (cbHYPE) on Base Adds metadata and icons for two Coinbase-wrapped assets on Base (eip155:8453). Name, symbol and decimals are read from the contracts via eth_call and cross-checked against Blockscout. Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds metadata and icons for two Coinbase-wrapped ERC-20 assets on Base (
eip155:8453). Neither address had an entry in this repo, so MetaMask currently shows them without a name/symbol/icon and would fall back to 18 decimals for cbZEC (the contract uses 8).Tokens
erc200xB2000000000000000000008501b13360000cb2ECcbZECtrueicons/eip155:8453/erc20:0xB2000000000000000000008501b13360000cb2EC.svgeth_callvia base-rpc.publicnode.com and mainnet.base.org; Blockscout token page; Basescan0xB200000000000000000000451d033a5000cb479ecbHYPEtrueicons/eip155:8453/erc20:0xB200000000000000000000451d033a5000cb479e.svgeth_callvia base-rpc.publicnode.com and mainnet.base.org; Blockscout token page; BasescanCAIP-19 asset IDs:
eip155:8453/erc20:0xB2000000000000000000008501b13360000cb2ECeip155:8453/erc20:0xB200000000000000000000451d033a5000cb479eNo overrides.
name,symbolanddecimalsare taken verbatim from the contracts. The naming matches the existing convention for this family in the repo, e.g.Coinbase Wrapped MEGA/cbMEGA(metadata/eip155:8453/erc20:0xcb111E6A2a3bde90856D299d61341ac302167D23.json).Verification
name(),symbol()anddecimals()were read directly from Base viaeth_callagainst two independent public RPC providers (base-rpc.publicnode.comandmainnet.base.org). Both return identical results:0xB2000000000000000000008501b13360000cb2EC->Coinbase Wrapped ZEC,cbZEC,80xB200000000000000000000451d033a5000cb479e->Coinbase Wrapped Hyperliquid,cbHYPE,18Cross-checked against Blockscout, which independently reports the same name/symbol/decimals,
type: ERC-20,is_contract: true,is_scam: falseandreputation: okfor both addresses.totalSupply()returns non-zero for both. Both addresses are already EIP-55 checksummed as written above (confirmed withethereumjs-util.toChecksumAddress).The same two addresses return empty code on Ethereum mainnet, so these entries are Base-only and no other chains are added.
Reviewer caveats worth a second pair of eyes:
Icons
The icons are the official marks for these two assets as supplied by the issuer. They arrived as 320x320 RGBA PNGs (a blue
#0052FFring and glyph on a white disc with transparent corners), which conflicts with STYLEGUIDE.md in two ways: a circular background with transparent corners, and artwork running edge to edge with no safe-area padding.So each mark was converted to a vector and re-laid out rather than committed as-is:
#0052FFon white), so both icons stay legible in light and dark mode; checked by rendering at 16, 24, 32 and 48px on both backgrounds.<rect>+<path>geometry, no embedded rasters,<filter>,<style>blocks or nested SVGs. ~5KB and ~4KB.Checks
npm run asset:setused to create the files, thennpm run asset:verifyfor both assets — passesnpm test— 702/702 passingicons/andmetadata/are touched;contract-map.jsonis generated separately, matching recent asset PRs