Remove non-english wordlists #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
remove-non-english-wordlists
branch
from
d61ec73 to
b2d2d79
Compare
adonesky1
force-pushed
the
remove-non-english-wordlists
branch
from
b2d2d79 to
0c56da5
Compare
adonesky1
force-pushed
the
remove-non-english-wordlists
branch
from
0c56da5 to
c766618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of an effort to reduce the bundle size of the extension we are looking to remove extraneous word-lists from our bundle. Currently we do not support SRP generation or recovery with non-english words, and there is no near to medium plan to support non-English SRPs.
As you can see, currently these unused wordlist json files are increasing our bundle by around 200kb:
