Skip to content

refactor!: remove InternalAccount.metadata.snap.{name,enabled} #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Apr 30, 2025

Those metadata should be pulled out from the SnapController itself to avoid duplicated state and potential inconsistencies.

This would also remove some non-needed state-watch on the AccountsController (since we are listening to SnapController:stateChange to update those accordingly, thus triggering some other AccountsController:stateChange which could be avoided).

@ccharly ccharly requested a review from a team as a code owner April 30, 2025 09:52
@ccharly
Copy link
Contributor Author

ccharly commented Apr 30, 2025

@metamaskbot publish-preview

@ccharly ccharly changed the title refactor: remove account.metadata.snap.{name,enabled} refactor!: remove InternalAccount.metadata.snap.{name,enabled} Apr 30, 2025
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "17.5.0-33a98a2",
  "@metamask-previews/eth-hd-keyring": "12.1.0-33a98a2",
  "@metamask-previews/eth-ledger-bridge-keyring": "11.0.3-33a98a2",
  "@metamask-previews/eth-simple-keyring": "10.0.0-33a98a2",
  "@metamask-previews/eth-trezor-keyring": "8.0.0-33a98a2",
  "@metamask-previews/keyring-internal-api": "6.0.1-33a98a2",
  "@metamask-previews/keyring-internal-snap-client": "4.0.2-33a98a2",
  "@metamask-previews/eth-snap-keyring": "12.1.1-33a98a2",
  "@metamask-previews/keyring-snap-client": "4.1.0-33a98a2",
  "@metamask-previews/keyring-snap-sdk": "3.2.0-33a98a2",
  "@metamask-previews/keyring-utils": "3.0.0-33a98a2"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: performance degradation during account creation
1 participant