feat(keyring-snap-bridge): add TTL for internal options #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
changed the title
gantunesr
reviewed
Mar 28, 2025
| * Default TTL for internal options. Past that time, the internal options will | ||
| * be considered outdated and will be removed automatically. | ||
| */ | ||
| export const DEFAULT_INTERNAL_OPTIONS_TTL_SECS = 60 * 60; // 1 hour |
There was a problem hiding this comment.
Is there any motivation for it to be one hour or was it chosen arbitrarily?
| /** | ||
| * Cleanup outdated internal options. | ||
| * | ||
| * @returns The number of entries that have been deleted. |
| @@ -347,6 +382,10 @@ export class SnapKeyring extends EventEmitter { | |||
| this.#getInternalOptionsOrDefaults(snapId, metamask?.correlationId), | |||
| ); | |||
|
|
|||
| // To avoid having a `setInterval` to do the cleanup, we run it explicitly from | |||
| // time to time. | |||
| await this.cleanupInternalOptions(); | |||
There was a problem hiding this comment.
Will this check all snaps for each account creation event?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a TTL to the new internal options features to avoid having leaking resources if a Snap does not properly re-emit its correlation ID.