Skip to content

Azure mass archive#53

Open
Erica Neininger (ericaneininger) wants to merge 7 commits into
MetOffice:mainfrom
ericaneininger:azure_mass_archive
Open

Azure mass archive#53
Erica Neininger (ericaneininger) wants to merge 7 commits into
MetOffice:mainfrom
ericaneininger:azure_mass_archive

Conversation

@ericaneininger
Copy link
Copy Markdown
Collaborator

@ericaneininger Erica Neininger (ericaneininger) commented May 5, 2026

PR Summary

Code Reviewer: Pierre Siddall (@Pierre-siddall)

Update PostProc app to permit archive to the new Azure MASS system.

closes:#51

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • I have tested this change locally, using the Moci rose-stem suite
  • [NA] If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)

rose-stem will only test the unit tests, as it does not push to MASS

I've also run a copy of the MOCI GAL test suite: u-dx886 with this branch

Test Suite Results - moci - TEST_moci53/run1

Suite Information

Item Value
Suite Name TEST_moci53/run1
Suite User erica.neininger
Workflow Start 2026-05-05T13:53:14
Groups Run postproc
Dependency Reference Main Like
moci ericaneininger/moci@azure_mass_archive False
SimSys_Scripts MetOffice/SimSys_Scripts@main True

Task Information

✅ succeeded tasks - 99

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • [NA] Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

Comment thread rose-meta/archive_and_meaning/postproc/HEAD/rose-meta.conf Outdated
@ericaneininger
Copy link
Copy Markdown
Collaborator Author

@jonseddon
Copy link
Copy Markdown
Contributor

Tested with Az-MASS in t-dx413/run2 and z-dx413/run1 for both values of risk appetite. Tested against moomin with m-dx413/run2 and confirmed that the changes don't affect the usage of moomin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants