Allow applications partitioning meshes to specify partition constraints (imposed by multigrid)#290
Draft
mo-rickywong wants to merge 1 commit intoMetOffice:mainfrom
Draft
Conversation
This was referenced Feb 27, 2026
|
I run the lfric_core rose stem tests successfully, everything seems in order: Test Suite Results - lfric_core - EnforcePartitionRestrictions/run1Suite Information
Task Information✅ succeeded tasks - 384 |
ukmo-juan-castillo
left a comment
There was a problem hiding this comment.
Everything seems in order, just a minor comment
| ! Equal divisions are only required if there are maps between meshes | ||
| if (any_maps) then | ||
| if (check_constraints) then | ||
| call log_event("Performing partition constraints.", log_level_debug) |
There was a problem hiding this comment.
The print line should probably be: 'Checking partition constraints'
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @ukmo-juan-castillo
Code Reviewer: @mike-hobson
ticket:4630 relocated checks/code-path for constraints on partitions when using
MultiGridwithin the the partitioners. This is a check that the partitioner (or infrastructure) should not be performing (it's a Gungho Science feature).The contraints on multigrid are being triggered if the mesh file from which a mesh was read, contained intergrid maps, regardless of whether the application had any interest in multigrid (e.g. Lfric2Lfric re-gridding). This change provides logic for applications to specify whether they are concerned with "Multigrid" constraints.
Ideally, the checks should be relocated to
Gungho Science. This change achieves the desired outcome without compounding ticket:4630 complexity.Linked PRs
Blocking PRs
Code Quality Checklist
Testing
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review