Skip to content

#920: add halo removal for SI3#922

Merged
Lauren Boon (mo-laurenboon) merged 1 commit into
mainfrom
920_add_halo_removal_for_SI3
May 18, 2026
Merged

#920: add halo removal for SI3#922
Lauren Boon (mo-laurenboon) merged 1 commit into
mainfrom
920_add_halo_removal_for_SI3

Conversation

@mo-laurenboon
Copy link
Copy Markdown
Collaborator

Closes issue #920

@mo-laurenboon
Copy link
Copy Markdown
Collaborator Author

I anticipate that no further changes will be required, however I am running all unit tests and an adhoc run of UKCM2-0-LL to confirm that the removal is applying as expected before marking as ready for review.

@mo-laurenboon
Copy link
Copy Markdown
Collaborator Author

All unit tests passing

@mo-laurenboon
Copy link
Copy Markdown
Collaborator Author

Lauren Boon (mo-laurenboon) commented May 13, 2026

I have completed an adhoc workflow run of ukcm2-0-LL historical with the following variables:

  • seaIce/siflswdbot_tavg-u-hxy-si@day:ind/icemod
  • seaIce/simpconc_tavg-u-hxy-si@day:ind/icemod
  • seaIce/simpthick_tavg-u-hxy-si@day:ind/icemod
  • seaIce/sidmasstranx_tavg-u-hxy-u@mon:inm/icemod
  • seaIce/siflcondbot_tavg-u-hxy-si@mon:inm/icemod
  • seaIce/siconc_tavg-u-hxy-u@mon:inm/icemod

Output can be seen in my data files under the testing_SI3_halo_removal directory. A quick ncview of these files appears to show the expected outcome of the fix. These output files should be checked as part of any review to confirm this.

Workflow runs as expected with no errors or job failures.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mo-laurenboon Lauren Boon (mo-laurenboon) merged commit a8b74e5 into main May 18, 2026
1 check passed
@mo-laurenboon Lauren Boon (mo-laurenboon) deleted the 920_add_halo_removal_for_SI3 branch May 18, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants