#920: add halo removal for SI3#922
Merged
Merged
Conversation
Collaborator
Author
|
I anticipate that no further changes will be required, however I am running all unit tests and an adhoc run of UKCM2-0-LL to confirm that the removal is applying as expected before marking as ready for review. |
Collaborator
Author
|
All unit tests passing |
Collaborator
Author
|
I have completed an adhoc workflow run of ukcm2-0-LL historical with the following variables:
Output can be seen in my data files under the testing_SI3_halo_removal directory. A quick ncview of these files appears to show the expected outcome of the fix. These output files should be checked as part of any review to confirm this. Workflow runs as expected with no errors or job failures. |
Matthew Mizielinski (matthew-mizielinski)
approved these changes
May 18, 2026
Collaborator
Matthew Mizielinski (matthew-mizielinski)
left a comment
There was a problem hiding this comment.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #920