#495 Fix populate_inventory#916
Open
Jared Drayton (mo-jareddrayton) wants to merge 2 commits into
Open
Conversation
Jared Drayton (mo-jareddrayton)
requested a review
from Matthew Mizielinski (matthew-mizielinski)
Collaborator
|
Collaborator
Matthew Mizielinski (matthew-mizielinski)
left a comment
Matthew Mizielinski (matthew-mizielinski)
left a comment
There was a problem hiding this comment.
A couple of thoughts
| formatter_class=argparse.RawDescriptionHelpFormatter) | ||
| parser.add_argument( | ||
| '-i', '--root_inventory_dir', type=str, default=arguments.root_inventory_dir, | ||
| '-i', '--root_inventory_dir', type=str, |
Collaborator
There was a problem hiding this comment.
if this is now a required argument rather than relying on defaults we should make it a required positional argument
Matthew Mizielinski (matthew-mizielinski)
requested changes
May 18, 2026
Jared Drayton (mo-jareddrayton)
requested a review
from Matthew Mizielinski (matthew-mizielinski)
Matthew Mizielinski (matthew-mizielinski)
approved these changes
May 19, 2026
Collaborator
Matthew Mizielinski (matthew-mizielinski)
left a comment
Matthew Mizielinski (matthew-mizielinski)
left a comment
There was a problem hiding this comment.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #495
Have tested on AZ-Mass and works as expected.
Shall I go ahead and obliterate any CREPP references Matthew Mizielinski (@matthew-mizielinski) ?