#861 Initial working coordinate replacement for NEMO#904
#861 Initial working coordinate replacement for NEMO#904Jared Drayton (mo-jareddrayton) wants to merge 3 commits into
Conversation
Jared Drayton (mo-jareddrayton)
requested a review
from Matthew Mizielinski (matthew-mizielinski)
Matthew Mizielinski (matthew-mizielinski)
left a comment
Matthew Mizielinski (matthew-mizielinski)
left a comment
There was a problem hiding this comment.
Looks like an elegant solution -- could do with documenting how to produce the required coordinates files
Matthew Mizielinski (matthew-mizielinski)
left a comment
Matthew Mizielinski (matthew-mizielinski)
left a comment
There was a problem hiding this comment.
Generally looks good -- Could you double check the model config files; in a few CMIP6 UKESM1-0 and CMIP7 UKCM2 the replacement_coordinate_files entry is a list, but in most it is still a string. I couldn't obviously see this difference being handled in the code and I think it would be clearer if you did a global replace of
"replacement_coordinate_files": "cice_eORCA1_coords.nc", with
"replacement_coordinate_files": ["cice_eORCA1_coords.nc"],
and similarly for the eORCA025 equivalent
| """ | ||
| ancil_files = get_ancil_files(request) | ||
| replacment_coordinates_file = get_replacement_coordinates_file(request) | ||
| replacment_coordinates_file = get_replacement_coordinate_files(request) |
There was a problem hiding this comment.
pedantry: spelling of replacement
Matthew Mizielinski (matthew-mizielinski)
left a comment
Matthew Mizielinski (matthew-mizielinski)
left a comment
There was a problem hiding this comment.
Just marking as changes needed for clarity on PR page
2 participants
Closes #861
replacement_coordinates_filetoreplacement_coordinate_filesand made it a list. Similar to how the ancil files work in the model.json. (I haven't changed the naming everywhere just yet in case this changes after inital review)