#835 replace test copyright headers with ruff rule CPY#836
Open
mo-jareddrayton wants to merge 3 commits intomainfrom
Open
#835 replace test copyright headers with ruff rule CPY#836mo-jareddrayton wants to merge 3 commits intomainfrom
mo-jareddrayton wants to merge 3 commits intomainfrom
Conversation
matthew-mizielinski
approved these changes
Mar 5, 2026
Collaborator
matthew-mizielinski
left a comment
matthew-mizielinski
left a comment
There was a problem hiding this comment.
LGTM and makes this test a lot easier.
Collaborator
|
I take it that if we go ahead with this change we're just going to have to be aware from now on that it doesn't check non python files as opposed to the previous copyright checker which checked all of them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #835
As noted by @mo-gill the existing
test_coding_standards.pydoesn't actually test coding standards anymore and only checks for the copyright/license header. This PR replaces those tests incddsandmip_convertwith theruffruleCPY(see https://docs.astral.sh/ruff/rules/#flake8-copyright-cpy)A couple other changes include the removal of some spurious shebang lines and enabling the
previewmode onrufffor theCPYrule.