#826: allow processing of gregorian calendar under the name standard#827
Open
mo-laurenboon wants to merge 6 commits intomainfrom
Open
#826: allow processing of gregorian calendar under the name standard#827mo-laurenboon wants to merge 6 commits intomainfrom
mo-laurenboon wants to merge 6 commits intomainfrom
Conversation
Collaborator
Author
|
These changes have been tested using cdds_request_1pctCO2_ll.cfg from nightly tests. UPDATE : trial run as described above completed with no errors. |
Collaborator
Author
|
All tests passing on my end |
mo-laurenboon
requested review from
matthew-mizielinski,
mo-gill and
mo-jareddrayton
and removed request for
matthew-mizielinski
Collaborator
Author
|
A complete adhoc run of all nightly tests has been run using this branch along with the CDDS-nightly tests branch 11_add_UKCM2-0-LL. The logs for these can be accessed under my user on cylc review. They appear to be running successfully without issue so far. |
Collaborator
matthew-mizielinski
left a comment
matthew-mizielinski
left a comment
There was a problem hiding this comment.
rename the constant and a couple of minor tweaks, but otherwise looks good.
cdds/cdds/convert/configure_workflow/configure_template_variables.py
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Pr comments and merge conflicts resolved. A re run of all tests passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #826