Skip to content

32 add ancil load metadata#110

Draft
Theo Geddes (mo-tgeddes) wants to merge 20 commits into
MetOffice:mainfrom
mo-tgeddes:32_add_ancil_load_metadata
Draft

32 add ancil load metadata#110
Theo Geddes (mo-tgeddes) wants to merge 20 commits into
MetOffice:mainfrom
mo-tgeddes:32_add_ancil_load_metadata

Conversation

@mo-tgeddes
Copy link
Copy Markdown
Collaborator

Closes #

To be completed prior to review request and updated as required during the review process.

If the answer to an item on the list is not applicable, feel free to replace the checkbox with 'N/A' to give extra clarity.

All developers are reminded to follow the ancil working practices


Branch

Related branches (e.g. contrib):

[please link any related branches here]

ANTS rose stem logs

[please enter the workflow name here as it has been run e.g. ants-trunk/run5]

contrib rose stem logs

[please enter the workflow name here as it has been run e.g. ants-contrib/run1]


Testing

For core ANTS only tests, the bare minimum that will be accepted is the --group=unittests but many, if not most, changes will need to test other groups to ensure they meet reviewer expectations. In general, it should be possible and is advised to run the --group=all group prior to review submission as this will catch any consequential issues. Additionally you must run the contrib tests, pointing at your branch, with --group=all to capture any behaviour changes affecting Science codes.

If your change will alter existing science results, you will need to seek appropriate Scientific validation and confirm that the model has been initialised with your new development. Inspecting a change in xconv/pyplot/visualiser of choice is not sufficient to demonstrate the model can be initialised from your file.


Impact of change

  • This will maintain results for ANTS rose stem --group=all tests
  • This will this maintain results for contrib rose stem --group=all tests
  • If this change adds a new capability, evidence has been supplied to show testing of ancillary generation across different resolutions e.g. For global ancillary generation capabilities for use in NWP n1280e is expected to have been tested
  • This change has significantly impacted required resources (runtime and memory) in existing ancillary generation (if yes, give details)
  • This change alters existing ancils
Add further comments/details for your reviewers here on the impacts of the change......

Approvals for this change

  • I have approval from the ANTS core development team for these changes

New functionality further testing

  • If adding new functionality to existing codes, I confirm that the new code doesn't change results when it is switched off and ''works'' when switched on
  • Unittests have been added
  • Rose stem tests have been added for any new functionality
  • If adding new functionality please confirm that the new code compares across different standard decompositions.
  • I have not encountered any failures in my rose-stem output(s)
    These tasks must succeed for your ticket to pass review.
  • I have remembered to run the code style check tasks/tools
Add details of any further testing here.

Other

  • I read the Contributor Licence Agreement
  • I have added my name and affiliation to the Contributors list if I am not already on there.
  • The issue labels, milestones, etc. are correct
  • Links to all related issues have been provided in the pull request description
  • I have requested a code reviewer
  • Source data has been added or changed - please include a link to the license
I confirm that all code is my own and that my contributions are not subject to copyright or license restrictions (see Contributor Licence Agreement). your name
I confirm I have not knowingly violated intellectual property rights (IPR) and have taken sensible measures to prevent doing so, including appropriate attribution for usage of Generative AI. I confirm that this work is my own, and I understand that it is my responsibility to ensure I am not violating others’ IPR. This includes taking reasonable steps to ensure that all tools used while creating this contribution did not infringe IPR. your name
Please add any further notes here. If Generative AI tools have been used, a brief summary (e.g. "Github copilot used to add extra unittests") should be provided.

Rose stem logs

Please copy in the contents of your trac_status.log file(s) below (found in the cylc-run directory for your rose stem run) to your rose-stem testing here. Note: if your changes lead to a change in answers, you must run rose stem --group=all to help ensure all affected configurations has been flagged up.

Add workflow_status.log contents for ANTS rose-stem here.

Add trac_status.log contents for contrib rose-stem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant